Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/ui/webui/options/manage_profile_handler.cc

Issue 638063002: Cleanup: Add a NOTREACHED() when selecting a profile photo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/notreached/check/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/manage_profile_handler.cc
diff --git a/chrome/browser/ui/webui/options/manage_profile_handler.cc b/chrome/browser/ui/webui/options/manage_profile_handler.cc
index 4f00931e0496c2672b168de479b847a96c352dc1..55656dd271b2d56e6963e4c085acc40643b1eb76 100644
--- a/chrome/browser/ui/webui/options/manage_profile_handler.cc
+++ b/chrome/browser/ui/webui/options/manage_profile_handler.cc
@@ -359,6 +359,9 @@ void ManageProfileHandler::SetProfileIconAndName(const base::ListValue* args) {
pref_service->SetInteger(prefs::kProfileAvatarIndex, new_icon_index);
pref_service->SetBoolean(prefs::kProfileUsingDefaultAvatar, false);
pref_service->SetBoolean(prefs::kProfileUsingGAIAAvatar, false);
+ } else {
+ // Only default avatars and Gaia account photos are supported.
+ CHECK(false);
}
ProfileMetrics::LogProfileUpdate(profile_file_path);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698