Issue 63803002: Remove RenderWidgetHost::AddCreatedCallback as part of removing that pattern. The tests which use t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63803002: Remove RenderWidgetHost::AddCreatedCallback as part of removing that pattern. The tests which use t… (Closed)

Created:
7 years, 1 month ago by jam

Modified:
7 years, 1 month ago

Reviewers:
lazyboy

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove RenderWidgetHost::AddCreatedCallback as part of removing that pattern. The tests which use this are disabled since a RenderWidget isn't used for AutoFill anymore according to the bug. So when the test is rewritten a new way will have to be found. In the meantime we should remove this so that more callers don't get added. BUG=277617 R=lazyboy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233517

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -38 lines)			Patch
M	chrome/browser/apps/web_view_interactive_browsertest.cc	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View	3 chunks	+0 lines, -21 lines	0 comments	Download
M	content/public/browser/render_widget_host.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages