Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: chrome/browser/apps/web_view_interactive_browsertest.cc

Issue 63803002: Remove RenderWidgetHost::AddCreatedCallback as part of removing that pattern. The tests which use t… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/web_view_interactive_browsertest.cc
===================================================================
--- chrome/browser/apps/web_view_interactive_browsertest.cc (revision 233297)
+++ chrome/browser/apps/web_view_interactive_browsertest.cc (working copy)
@@ -270,15 +270,12 @@
rwh->ForwardMouseEvent(mouse_event);
}
+ // TODO(lazyboy): implement
class PopupCreatedObserver {
public:
PopupCreatedObserver() : created_(false), last_render_widget_host_(NULL) {
- created_callback_ = base::Bind(
- &PopupCreatedObserver::CreatedCallback, base::Unretained(this));
- content::RenderWidgetHost::AddCreatedCallback(created_callback_);
}
virtual ~PopupCreatedObserver() {
- content::RenderWidgetHost::RemoveCreatedCallback(created_callback_);
}
void Reset() {
created_ = false;
@@ -294,14 +291,6 @@
}
private:
- void CreatedCallback(content::RenderWidgetHost* rwh) {
- last_render_widget_host_ = rwh;
- if (message_loop_.get())
- message_loop_->Quit();
- else
- created_ = true;
- }
- content::RenderWidgetHost::CreatedCallback created_callback_;
scoped_refptr<content::MessageLoopRunner> message_loop_;
bool created_;
content::RenderWidgetHost* last_render_widget_host_;
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698