Remove ~GrIORef since last remaining virtual and now all inline

include/gpu/GrGpuResource.h

Index: include/gpu/GrGpuResource.h
diff --git a/include/gpu/GrGpuResource.h b/include/gpu/GrGpuResource.h
index afd9275d472fc447dd38650dd89cca95a918baa1..c63906281e8a5f3982ad0f6e469b21a73bbd7a03 100644
--- a/include/gpu/GrGpuResource.h
+++ b/include/gpu/GrGpuResource.h
@@ -41,7 +41,14 @@ class GrContext;
 template <typename DERIVED> class GrIORef : public SkNoncopyable {
 public:
     SK_DECLARE_INST_COUNT_ROOT(GrIORef)
-    virtual ~GrIORef();
+
+    virtual ~GrIORef() {

[mtklein, 2014/10/08 17:57:14]

Drop this virtual?  Seems like you don't have any virtual methods any more, so a
bit of a waste.

It's particularly bad after this CL: with all the methods inlined,  there's no
.o to pin the vtable to,  so you'll end up with a distinct vtable for GrIORef in
every compilation unit it's included into (or maybe just destroyed within).

[bsalomon, 2014/10/08 18:01:53]

Good point, will remove the virtual

+        SkASSERT(0 == fRefCnt);
+        SkASSERT(0 == fPendingReads);
+        SkASSERT(0 == fPendingWrites);
+        // Set to invalid values.
+        SkDEBUGCODE(fRefCnt = fPendingReads = fPendingWrites = -10;)
+    }
 
     // Some of the signatures are written to mirror SkRefCnt so that GrGpuResource can work with
     // templated helper classes (e.g. SkAutoTUnref). However, we have different categories of