Remove ~GrIORef since last remaining virtual and now all inline

include/gpu/GrGpuResource.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrGpuResource_DEFINED
 #define GrGpuResource_DEFINED
 
@@ skipping 23 matching lines @@
  *
  * The latter two ref types are private and intended only for Gr core code.
  *
  * When an item is purgable DERIVED:notifyIsPurgable() will be called (static poly morphism using
  * CRTP). GrIORef and GrGpuResource are separate classes for organizational reasons and to be
  * able to give access via friendship to only the functions related to pending IO operations.
  */
 template <typename DERIVED> class GrIORef : public SkNoncopyable {
 public:
     SK_DECLARE_INST_COUNT_ROOT(GrIORef)
-    virtual ~GrIORef();
+
+    virtual ~GrIORef() {

[mtklein, 2014/10/08 17:57:14]

Drop this virtual?  Seems like you don't have any virtual methods any more, so a
bit of a waste.

It's particularly bad after this CL: with all the methods inlined,  there's no
.o to pin the vtable to,  so you'll end up with a distinct vtable for GrIORef in
every compilation unit it's included into (or maybe just destroyed within).

[bsalomon, 2014/10/08 18:01:53]

Good point, will remove the virtual

+        SkASSERT(0 == fRefCnt);
+        SkASSERT(0 == fPendingReads);
+        SkASSERT(0 == fPendingWrites);
+        // Set to invalid values.
+        SkDEBUGCODE(fRefCnt = fPendingReads = fPendingWrites = -10;)
+    }
 
     // Some of the signatures are written to mirror SkRefCnt so that GrGpuResource can work with
     // templated helper classes (e.g. SkAutoTUnref). However, we have different categories of
     // refs (e.g. pending reads). We also don't require thread safety as GrCacheable objects are
     // not intended to cross thread boundaries.
     void ref() const {
         this->validate();
         ++fRefCnt;
     }
 
@@ skipping 205 matching lines @@
     GrResourceCacheEntry*   fCacheEntry;  // NULL if not in cache
     const uint32_t          fUniqueID;
 
     GrResourceKey           fScratchKey;
 
     typedef GrIORef<GrGpuResource> INHERITED;
     friend class GrIORef<GrGpuResource>; // to access notifyIsPurgable.
 };
 
 #endif