Remove ~GrIORef since last remaining virtual and now all inline

Remove ~GrIORef since last remaining virtual and now all inline

TBR=reed@google.com
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/81e64484ff801ad2c346722e41a3f4216a15b6c8

[bsalomon, 2014-10-08 17:50:22]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-10-08 17:51:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/638003003/1

[reed1, 2014-10-08 17:55:41]

lgtm

too bad it has to be public

[mtklein, 2014-10-08 17:57:14]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-10-08 17:57:14]

https://codereview.chromium.org/638003003/diff/1/include/gpu/GrGpuResource.h
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/638003003/diff/1/include/gpu/GrGpuResource.h#...
include/gpu/GrGpuResource.h:45: virtual ~GrIORef() {
Drop this virtual?  Seems like you don't have any virtual methods any more, so a
bit of a waste.

It's particularly bad after this CL: with all the methods inlined,  there's no
.o to pin the vtable to,  so you'll end up with a distinct vtable for GrIORef in
every compilation unit it's included into (or maybe just destroyed within).

[bsalomon, 2014-10-08 18:01:53]

https://codereview.chromium.org/638003003/diff/1/include/gpu/GrGpuResource.h
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/638003003/diff/1/include/gpu/GrGpuResource.h#...
include/gpu/GrGpuResource.h:45: virtual ~GrIORef() {
On 2014/10/08 17:57:14, mtklein wrote:
> Drop this virtual?  Seems like you don't have any virtual methods any more, so
a
> bit of a waste.
> 
> It's particularly bad after this CL: with all the methods inlined,  there's no
> .o to pin the vtable to,  so you'll end up with a distinct vtable for GrIORef
in
> every compilation unit it's included into (or maybe just destroyed within).

Good point, will remove the virtual

[bsalomon, 2014-10-08 18:01:57]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2014-10-08 18:08:27]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-10-08 18:09:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/638003003/40001

[bsalomon, 2014-10-08 18:41:50]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2014-10-08 18:41:57]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-10-08 18:42:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/638003003/40001

[commit-bot: I haz the power, 2014-10-08 18:42:15]

Committed patchset #3 (id:40001) as 81e64484ff801ad2c346722e41a3f4216a15b6c8

[mtklein, 2014-10-08 19:01:44]

On 2014/10/08 18:42:15, I haz the power (commit-bot) wrote:
> Committed patchset #3 (id:40001) as 81e64484ff801ad2c346722e41a3f4216a15b6c8

Oh boy, bot meltdown.  Maybe i gave some bad advice.  How do you destroy your
GrIORefs?  Perhaps the destructor really should be calling the destructor of
DERIVED?

[bsalomon, 2014-10-08 19:05:52]

On 2014/10/08 19:01:44, mtklein wrote:
> On 2014/10/08 18:42:15, I haz the power (commit-bot) wrote:
> > Committed patchset #3 (id:40001) as 81e64484ff801ad2c346722e41a3f4216a15b6c8
> 
> Oh boy, bot meltdown.  Maybe i gave some bad advice.  How do you destroy your
> GrIORefs?  Perhaps the destructor really should be calling the destructor of
> DERIVED?

Yeah just realized that myself... they are destroyed as GrIORefs (gulp). That'll
probably change in the future, but for now calling ~DERIVED seems right.