Issue 637863005: Revert of Start to vectorize SkTileGrid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 637863005: Revert of Start to vectorize SkTileGrid. (Closed)

Created:
6 years, 2 months ago by mtklein

Modified:
6 years, 2 months ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Start to vectorize SkTileGrid. (patchset #48 id:1670001 of https://codereview.chromium.org/634543004/) Reason for revert: breaks chrome GPU debug bots Original issue's description: > Start to vectorize SkTileGrid. > > This adds Sk4x.h to help. > > BUG=skia:3041 > > Committed: https://skia.googlesource.com/skia/+/90c7992bfc6330f070f7704d63372a0ec8410170 > > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot > > Committed: https://skia.googlesource.com/skia/+/958e9628d5f9a81aeafa78572cb4afc4b19a455a TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3041 Committed: https://skia.googlesource.com/skia/+/dba3e64ab9bbeac5a8b4fed6d03665cc7a5cf514

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -483 lines)			Patch
M	bench/GeometryBench.cpp	View	5 chunks	+2 lines, -62 lines	0 comments	Download
M	gyp/common_conditions.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkTypes.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	src/core/Sk4x.h	View	1 chunk	+0 lines, -92 lines	0 comments	Download
D	src/core/Sk4x_clang.h	View	1 chunk	+0 lines, -125 lines	0 comments	Download
D	src/core/Sk4x_portable.h	View	1 chunk	+0 lines, -134 lines	0 comments	Download
M	src/core/SkTileGrid.h	View	2 chunks	+8 lines, -9 lines	0 comments	Download
M	src/core/SkTileGrid.cpp	View	4 chunks	+45 lines, -57 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637863005/1

6 years, 2 months ago (2014-10-20 17:43:30 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-20 17:44:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as dba3e64ab9bbeac5a8b4fed6d03665cc7a5cf514