Drop irrelevant DCHECK and re-enable SyncFileSystemApiTest.GetFileStatus

Drop irrelevant DCHECK and re-enable SyncFileSystemApiTest.GetFileStatus

BUG=421141
Committed: https://crrev.com/0b29873f5b44339b2582c894cb5293d8c4e30d20
Cr-Commit-Position: refs/heads/master@{#298663}

[tzik, 2014-10-08 04:56:21]

tzik@chromium.org changed reviewers:
+ nhiroki@chromium.org

[tzik, 2014-10-08 04:57:30]

PTL.

I believe it's safe to remove the DCHECK, and actually we can't hold the
condition on the shutdown phase of the browser.

[nhiroki, 2014-10-08 05:29:55]

lgtm

https://codereview.chromium.org/637823002/diff/1/storage/browser/fileapi/time...
File storage/browser/fileapi/timed_task_helper.cc (left):

https://codereview.chromium.org/637823002/diff/1/storage/browser/fileapi/time...
storage/browser/fileapi/timed_task_helper.cc:30:
DCHECK(task_runner_->RunsTasksOnCurrentThread());
Let me confirm my understanding... when task_runner_ was already shutdown, this
dtor is called on another task_runner and there is no remaining task. So we can
safely destruct the helper without this check.

[tzik, 2014-10-08 05:32:55]

On 2014/10/08 05:29:55, nhiroki wrote:
> lgtm
> 
>
https://codereview.chromium.org/637823002/diff/1/storage/browser/fileapi/time...
> File storage/browser/fileapi/timed_task_helper.cc (left):
> 
>
https://codereview.chromium.org/637823002/diff/1/storage/browser/fileapi/time...
> storage/browser/fileapi/timed_task_helper.cc:30:
> DCHECK(task_runner_->RunsTasksOnCurrentThread());
> Let me confirm my understanding... when task_runner_ was already shutdown,
this
> dtor is called on another task_runner and there is no remaining task. So we
can
> safely destruct the helper without this check.

Exactly!

[tzik, 2014-10-08 05:32:59]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-10-08 05:33:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637823002/1

[commit-bot: I haz the power, 2014-10-08 06:25:58]

Committed patchset #1 (id:1) as 3a1f024a3567d8dc65d536db1da3c5456009499d

[commit-bot: I haz the power, 2014-10-08 06:26:42]

Patchset 1 (id:??) landed as
https://crrev.com/0b29873f5b44339b2582c894cb5293d8c4e30d20
Cr-Commit-Position: refs/heads/master@{#298663}