Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: storage/browser/fileapi/timed_task_helper.cc

Issue 637823002: Drop irrelevant DCHECK and re-enable SyncFileSystemApiTest.GetFileStatus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "storage/browser/fileapi/timed_task_helper.h" 5 #include "storage/browser/fileapi/timed_task_helper.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/sequenced_task_runner.h" 9 #include "base/sequenced_task_runner.h"
10 10
11 namespace storage { 11 namespace storage {
12 12
13 struct TimedTaskHelper::Tracker { 13 struct TimedTaskHelper::Tracker {
14 explicit Tracker(TimedTaskHelper* timer) : timer(timer) {} 14 explicit Tracker(TimedTaskHelper* timer) : timer(timer) {}
15 15
16 ~Tracker() { 16 ~Tracker() {
17 if (timer) 17 if (timer)
18 timer->tracker_ = NULL; 18 timer->tracker_ = NULL;
19 } 19 }
20 20
21 TimedTaskHelper* timer; 21 TimedTaskHelper* timer;
22 }; 22 };
23 23
24 TimedTaskHelper::TimedTaskHelper(base::SequencedTaskRunner* task_runner) 24 TimedTaskHelper::TimedTaskHelper(base::SequencedTaskRunner* task_runner)
25 : task_runner_(task_runner), 25 : task_runner_(task_runner),
26 tracker_(NULL) { 26 tracker_(NULL) {
27 } 27 }
28 28
29 TimedTaskHelper::~TimedTaskHelper() { 29 TimedTaskHelper::~TimedTaskHelper() {
30 DCHECK(task_runner_->RunsTasksOnCurrentThread());
nhiroki 2014/10/08 05:29:55 Let me confirm my understanding... when task_runne
31 if (tracker_) 30 if (tracker_)
32 tracker_->timer = NULL; 31 tracker_->timer = NULL;
33 } 32 }
34 33
35 bool TimedTaskHelper::IsRunning() const { 34 bool TimedTaskHelper::IsRunning() const {
36 DCHECK(task_runner_->RunsTasksOnCurrentThread()); 35 DCHECK(task_runner_->RunsTasksOnCurrentThread());
37 return tracker_ != NULL; 36 return tracker_ != NULL;
38 } 37 }
39 38
40 void TimedTaskHelper::Start( 39 void TimedTaskHelper::Start(
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 82
84 void TimedTaskHelper::PostDelayedTask(scoped_ptr<Tracker> tracker, 83 void TimedTaskHelper::PostDelayedTask(scoped_ptr<Tracker> tracker,
85 base::TimeDelta delay) { 84 base::TimeDelta delay) {
86 task_runner_->PostDelayedTask( 85 task_runner_->PostDelayedTask(
87 posted_from_, 86 posted_from_,
88 base::Bind(&TimedTaskHelper::Fired, base::Passed(&tracker)), 87 base::Bind(&TimedTaskHelper::Fired, base::Passed(&tracker)),
89 delay); 88 delay);
90 } 89 }
91 90
92 } // namespace storage 91 } // namespace storage
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698