Issue 63773002: Disable incremental linking for the large modules in Debug static_library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63773002: Disable incremental linking for the large modules in Debug static_library. (Closed)

Created:
7 years, 1 month ago by Sébastien Marchand

Modified:
7 years, 1 month ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Disable incremental linking for the large modules in Debug static_library. If we don't do this then we get the following error (with chrome_frame_reliability_tests at least): LINK : fatal error LNK1210: exceeded internal ILK size limit; link with /INCREMENTAL:NO BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233832

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	build/common.gypi	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sébastien Marchand

Hey Scott, are you an appropriate owner for this ? If so PTAL. Thanks !

7 years, 1 month ago (2013-11-07 05:15:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/63773002/1

7 years, 1 month ago (2013-11-07 13:30:49 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=221336

7 years, 1 month ago (2013-11-07 17:17:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/63773002/1

7 years, 1 month ago (2013-11-07 17:26:37 UTC) #5

Message was sent while issue was closed.

Change committed as 233832

Expand Messages | Collapse Messages