Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: build/common.gypi

Issue 63773002: Disable incremental linking for the large modules in Debug static_library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 1605a797611de7abf6f060a0565b86352d5bf530..130f95ecb83db0f1b6e50f693147acd0b88814de 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1477,8 +1477,10 @@
# .obj files.
'incremental_chrome_dll%': 1,
}],
- # Don't do incremental linking for large modules on 32-bit.
- ['MSVS_OS_BITS==32', {
+ # Don't do incremental linking for large modules on 32-bit or when
+ # component=static_library as the toolchain fails due to the size of
+ # the .ilk files.
+ ['MSVS_OS_BITS==32 or component=="static_library"', {
'msvs_large_module_debug_link_mode%': '1', # No
},{
'msvs_large_module_debug_link_mode%': '2', # Yes
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698