Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 637593002: Add -Wno-invalid-offsetof to Mac and iOS builds too. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
tfarina, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add -Wno-invalid-offsetof to Mac and iOS builds too. We use this on Linux already, but for whatever reason wasn't a problem on iOS until using it in SkPaint. Mac 10.7 and 10.8 are showing this warning too, but seems -Werror is not enabled. CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Release-iOS-Trybot BUG=skia: Committed: https://skia.googlesource.com/skia/+/38ba4e0588bc01dedbe8b14cf990a6f4ffe92fc7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
mtklein
lgtm
6 years, 2 months ago (2014-10-07 16:39:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637593002/1
6 years, 2 months ago (2014-10-07 16:40:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 38ba4e0588bc01dedbe8b14cf990a6f4ffe92fc7
6 years, 2 months ago (2014-10-07 16:54:22 UTC) #5
tfarina
6 years, 2 months ago (2014-10-07 20:05:53 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/637593002/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/637593002/diff/1/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:512: '-Wno-invalid-offsetof',
looks fine, below too.

Powered by Google App Engine
This is Rietveld 408576698