Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gyp/common_conditions.gypi

Issue 637593002: Add -Wno-invalid-offsetof to Mac and iOS builds too. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index ca5c98c4d43f41f6901cb01a50a99bb053c8b5b2..4d06ffcc14221ea1fd4f85941b15a4fc8e127458 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -509,6 +509,7 @@
'WARNING_CFLAGS': [
'-Wall',
'-Wextra',
+ '-Wno-invalid-offsetof',
tfarina 2014/10/07 20:05:53 looks fine, below too.
'-Wno-unused-parameter',
'-Wno-uninitialized', # Disabled because we think GCC 4.2 is bad at this.
],
@@ -551,6 +552,7 @@
'SDKROOT': 'iphoneos',
'TARGETED_DEVICE_FAMILY': '1,2',
'OTHER_CPLUSPLUSFLAGS': [
+ '-Wno-invalid-offsetof',
'-fvisibility=hidden',
'-fvisibility-inlines-hidden',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698