Chromium Code Reviews Chromium Code Reviews
Issue
637503003:
Prefer using RenderSVGResourceMode when possible (Closed)
DescriptionPrefer using RenderSVGResourceMode when possible
It's not too difficult to keep track of when we're about to paint text,
so all methods in SVGInlineTextBoxPainter taking
RenderSVGResourceModeFlags can be adjusted to take RenderSVGResourceMode
instead, and then ApplyToTextMode can be ored in to the few (one) calls
where it's needed.
With the use (setting) of the ApplyToTextMode flag limited to a single
method, it makes sense to sink the calls to setTextDrawingMode out of
RenderSVGResource::updateGraphicsContext.
Bonus: Somewhat increased type-safety.
BUG=420022
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183398
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||||||||||||||||||||
