Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 637503003: Prefer using RenderSVGResourceMode when possible (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Prefer using RenderSVGResourceMode when possible It's not too difficult to keep track of when we're about to paint text, so all methods in SVGInlineTextBoxPainter taking RenderSVGResourceModeFlags can be adjusted to take RenderSVGResourceMode instead, and then ApplyToTextMode can be ored in to the few (one) calls where it's needed. With the use (setting) of the ApplyToTextMode flag limited to a single method, it makes sense to sink the calls to setTextDrawingMode out of RenderSVGResource::updateGraphicsContext. Bonus: Somewhat increased type-safety. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M Source/core/paint/SVGInlineTextBoxPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 5 chunks +9 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
6 years, 2 months ago (2014-10-07 15:47:11 UTC) #2
f(malita)
lgtm
6 years, 2 months ago (2014-10-07 16:46:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637503003/1
6 years, 2 months ago (2014-10-08 08:09:45 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 08:13:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183398

Powered by Google App Engine
This is Rietveld 408576698