Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 637413007: Fix histogram names. (Closed)

Created:
6 years, 2 months ago by Bence
Modified:
6 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix histogram names. Mark three histograms obsolete and add new ones in histograms.xml to enable access to histograms renamed in https://crrev.com/12710005. BUG=425723 Committed: https://crrev.com/fd4440e67bd92bd7b94d6e57ee8b445aebcda15e Cr-Commit-Position: refs/heads/master@{#300674}

Patch Set 1 #

Patch Set 2 : Obsolete old histograms. #

Total comments: 4

Patch Set 3 : Keep old affected histograms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 5 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Bence
Alexei: PTAL. Thank you.
6 years, 2 months ago (2014-10-21 21:07:46 UTC) #2
Alexei Svitkine (slow)
Please mark the old histograms as obsolete and make new entries for the new ones.
6 years, 2 months ago (2014-10-21 21:08:29 UTC) #3
Bence
Sorry for forgetting about that. PTAL.
6 years, 2 months ago (2014-10-21 21:21:36 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/637413007/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/637413007/diff/20001/tools/metrics/histograms/histograms.xml#oldcode57480 tools/metrics/histograms/histograms.xml:57480: - <affected-histogram name="Net.SSL_Connection_Latency"/> Please keep these lines here still, ...
6 years, 2 months ago (2014-10-21 21:24:33 UTC) #5
Bence
PTAL. https://codereview.chromium.org/637413007/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/637413007/diff/20001/tools/metrics/histograms/histograms.xml#oldcode57480 tools/metrics/histograms/histograms.xml:57480: - <affected-histogram name="Net.SSL_Connection_Latency"/> On 2014/10/21 21:24:33, Alexei Svitkine ...
6 years, 2 months ago (2014-10-21 21:27:41 UTC) #6
Alexei Svitkine (slow)
LGTM, please update your CL description before landing.
6 years, 2 months ago (2014-10-21 21:28:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637413007/40001
6 years, 2 months ago (2014-10-21 21:31:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/71069)
6 years, 2 months ago (2014-10-21 23:10:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637413007/40001
6 years, 2 months ago (2014-10-22 12:44:37 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-22 13:20:17 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 13:21:10 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fd4440e67bd92bd7b94d6e57ee8b445aebcda15e
Cr-Commit-Position: refs/heads/master@{#300674}

Powered by Google App Engine
This is Rietveld 408576698