Chromium Code Reviews Chromium Code Reviews
Issue 637413007:
Fix histogram names. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index f9cf99d7df9b2a71517452a2d7a5475955ca65fb..e4be189c60dedb7454e29ef6060dfca1c527160d 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -17944,6 +17944,14 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </histogram> |
| <histogram name="Net.SpdyConnectionLatency" units="milliseconds"> |
| + <obsolete> |
| + Replaced by Net.SpdyConnectionLatency_2 on 2014-10-21. |
| + </obsolete> |
| + <owner>rch@chromium.org</owner> |
| + <summary>Time from when the Connect() starts until it completes.</summary> |
| +</histogram> |
| + |
| +<histogram name="Net.SpdyConnectionLatency_2" units="milliseconds"> |
| <owner>rch@chromium.org</owner> |
| <summary>Time from when the Connect() starts until it completes.</summary> |
| </histogram> |
| @@ -18255,6 +18263,14 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </histogram> |
| <histogram name="Net.SSL_Connection_Latency" units="milliseconds"> |
| + <obsolete> |
| + Replaced by Net.SSL_Connection_Latency_2 on 2014-10-21. |
| + </obsolete> |
| + <owner>agl@chromium.org</owner> |
| + <summary>Time from when the Connect() starts until it completes.</summary> |
| +</histogram> |
| + |
| +<histogram name="Net.SSL_Connection_Latency_2" units="milliseconds"> |
| <owner>agl@chromium.org</owner> |
| <summary>Time from when the Connect() starts until it completes.</summary> |
| </histogram> |
| @@ -18273,6 +18289,17 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </histogram> |
| <histogram name="Net.SSL_Connection_Latency_Google" units="milliseconds"> |
| + <obsolete> |
| + Replaced by Net.SSL_Connection_Latency_Google2 on 2014-10-21. |
| + </obsolete> |
| + <owner>agl@chromium.org</owner> |
| + <summary> |
| + Time from when the Connect() starts until it completes for google.com and |
| + any subdomain of it. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Net.SSL_Connection_Latency_Google2" units="milliseconds"> |
| <owner>agl@chromium.org</owner> |
| <summary> |
| Time from when the Connect() starts until it completes for google.com and |
| @@ -57477,7 +57504,7 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <histogram_suffixes name="SSLFalseStart"> |
| <suffix name="FalseStart_enabled"/> |
| <suffix name="FalseStart_disabled"/> |
| - <affected-histogram name="Net.SSL_Connection_Latency"/> |
|
Alexei Svitkine (slow)
2014/10/21 21:24:33
Please keep these lines here still, so that old da
Bence
2014/10/21 21:27:41
Done.
|
| + <affected-histogram name="Net.SSL_Connection_Latency_2"/> |
| <affected-histogram name="PLT.BeginToFinish_LinkLoadNormal"/> |
| <affected-histogram name="PLT.BeginToFinish_NormalLoad"/> |
| </histogram_suffixes> |
| @@ -57485,8 +57512,8 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <histogram_suffixes name="SSLResumption"> |
| <suffix name="Resume_Handshake" label="Session Resumption"/> |
| <suffix name="Full_Handshake" label="Full"/> |
| - <affected-histogram name="Net.SSL_Connection_Latency"/> |
|
Alexei Svitkine (slow)
2014/10/21 21:24:33
Same here.
Bence
2014/10/21 21:27:41
Done.
|
| - <affected-histogram name="Net.SSL_Connection_Latency_Google"/> |
| + <affected-histogram name="Net.SSL_Connection_Latency_2"/> |
| + <affected-histogram name="Net.SSL_Connection_Latency_Google2"/> |
| </histogram_suffixes> |
| <histogram_suffixes name="StartupTimeBombAlarm" separator="."> |
