sync/internal_api/public/engine/model_safe_worker.h - Issue 637413003: Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/engine/model_safe_worker.h

Issue 637413003: Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/public/engine/model_safe_worker.h

diff --git a/sync/internal_api/public/engine/model_safe_worker.h b/sync/internal_api/public/engine/model_safe_worker.h

index 02f3ca1fa2b18f8ce100ffedbda7342b5edc2e99..b7e2b16afa87b9414c821e2a2b2e46400e11b50b 100644

--- a/sync/internal_api/public/engine/model_safe_worker.h

+++ b/sync/internal_api/public/engine/model_safe_worker.h

@@ -133,7 +133,12 @@ class SYNC_EXPORT ModelSafeWorker

// observation from sync thread when shutting down sync.

base::Lock working_loop_lock_;

base::MessageLoop* working_loop_;

- base::WaitableEvent working_loop_set_wait_;

+ // Callback passed with UnregisterForLoopDestruction. Normally this

Nicolas Zea 2014/10/17 16:16:52 nit: newline above

+ // remains unset/unused and is stored only if |working_loop_| isn't

+ // initialized by the time UnregisterForLoopDestruction is called.

+ // It is safe to copy and thread safe.

+ // See comments in model_safe_worker.cc for more details.

+ base::Callback<void(ModelSafeGroup)> unregister_done_callback_;

};

// A map that details which ModelSafeGroup each ModelType

« no previous file with comments | « chrome/browser/sync/glue/ui_model_worker.cc ('k') | sync/internal_api/public/engine/model_safe_worker.cc » ('j') | no next file with comments »