chrome/browser/sync/glue/ui_model_worker.cc - Issue 637413003: Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/ui_model_worker.cc

Issue 637413003: Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/sync_backend_registrar_unittest.cc ('k') | sync/internal_api/public/engine/model_safe_worker.h » ('j') | sync/internal_api/public/engine/model_safe_worker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/ui_model_worker.cc

diff --git a/chrome/browser/sync/glue/ui_model_worker.cc b/chrome/browser/sync/glue/ui_model_worker.cc

index 2d8bc7d1435d9a875d34e0cf7bb27b9151df9407..726deb6dfc70e4060f2c3e1294a4c4d1499f04f9 100644

--- a/chrome/browser/sync/glue/ui_model_worker.cc

+++ b/chrome/browser/sync/glue/ui_model_worker.cc

@@ -47,7 +47,6 @@ UIModelWorker::UIModelWorker(syncer::WorkerLoopDestructionObserver* observer)

void UIModelWorker::RegisterForLoopDestruction() {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- base::MessageLoop::current()->AddDestructionObserver(this);

SetWorkingLoopToCurrent();

}