chrome/browser/sync/glue/browser_thread_model_worker.cc - Issue 637413003: Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/browser_thread_model_worker.cc

Issue 637413003: Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/glue/browser_thread_model_worker.cc

diff --git a/chrome/browser/sync/glue/browser_thread_model_worker.cc b/chrome/browser/sync/glue/browser_thread_model_worker.cc

index 7f4024af61eac61ca1e21adece28f355172d0cbd..093d2828bf816a366f642d6ed90af6cee5c4717d 100644

--- a/chrome/browser/sync/glue/browser_thread_model_worker.cc

+++ b/chrome/browser/sync/glue/browser_thread_model_worker.cc

@@ -50,7 +50,6 @@ BrowserThreadModelWorker::~BrowserThreadModelWorker() {}

void BrowserThreadModelWorker::RegisterForLoopDestruction() {

if (BrowserThread::CurrentlyOn(thread_)) {

- base::MessageLoop::current()->AddDestructionObserver(this);

SetWorkingLoopToCurrent();

} else {

BrowserThread::PostTask(

« no previous file with comments | « no previous file | chrome/browser/sync/glue/history_model_worker.cc » ('j') | sync/internal_api/public/engine/model_safe_worker.h » ('J')