Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 637283004: Fix CanScrollOrientation method name. (Closed)

Created:
6 years, 2 months ago by Tima Vaisburd
Modified:
6 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix CanScrollOrientation method name. Change the method name from can_scroll_orientation() to CanScrollOrienattion() to comply with the style guide. This is a follow up to https://codereview.chromium.org/655783004 BUG=370892 Committed: https://crrev.com/87a47f52c9a940e8cc384bb4e08049e45e26fc63 Cr-Commit-Position: refs/heads/master@{#299803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M cc/animation/scrollbar_animation_controller_linear_fade.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/scrollbar_animation_controller_thinning.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_impl_base.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_impl_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
timav
Please review.
6 years, 2 months ago (2014-10-15 21:11:07 UTC) #2
timav
6 years, 2 months ago (2014-10-15 21:11:51 UTC) #4
timav
6 years, 2 months ago (2014-10-15 21:11:54 UTC) #5
aelias_OOO_until_Jul13
lgtm, sorry for missing this on my review.
6 years, 2 months ago (2014-10-15 21:12:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637283004/1
6 years, 2 months ago (2014-10-15 21:15:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 01:10:07 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 01:11:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87a47f52c9a940e8cc384bb4e08049e45e26fc63
Cr-Commit-Position: refs/heads/master@{#299803}

Powered by Google App Engine
This is Rietveld 408576698