Hide scrollbars when their dimensions are not scrollable.

Hide scrollbars when their dimensions are not scrollable.

Make scrollbars disappear by setting their opacity to 0
(i.e. making them completely transparent) when they
cannot be scrolled.

This CL has been reviewed on https://codereview.chromium.org/640063002/

BUG=370892
Committed: https://crrev.com/3ca6969326eaae1916766aa3ac62515ec83e5f01
Cr-Commit-Position: refs/heads/master@{#299628}

[timav, 2014-10-15 00:04:13]

timav@google.com changed reviewers:
+ aelias@chromium.org

[timav, 2014-10-15 00:06:45]

timav@google.com changed reviewers:
+ timav@google.com

[timav, 2014-10-15 00:06:46]

The issue is now associated with chromium instead of blink.
Please review.

[aelias_OOO_until_Jul13, 2014-10-15 00:11:33]

lgtm again

[timav, 2014-10-15 00:17:05]

The CQ bit was checked by timav@google.com

[commit-bot: I haz the power, 2014-10-15 00:18:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655783004/1

[commit-bot: I haz the power, 2014-10-15 02:19:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-15 02:20:53]

Patchset 1 (id:??) landed as
https://crrev.com/3ca6969326eaae1916766aa3ac62515ec83e5f01
Cr-Commit-Position: refs/heads/master@{#299628}

[danakj, 2014-10-15 15:39:52]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2014-10-15 15:39:52]

https://codereview.chromium.org/655783004/diff/1/cc/layers/scrollbar_layer_im...
File cc/layers/scrollbar_layer_impl_base.cc (right):

https://codereview.chromium.org/655783004/diff/1/cc/layers/scrollbar_layer_im...
cc/layers/scrollbar_layer_impl_base.cc:125: bool
ScrollbarLayerImplBase::can_scroll_orientation() const {
hacker_style functions should be for accessors, and defined in the header file.
If this is defined the .cc file it should NotBeHackerStyle.

[timav, 2014-10-15 18:12:05]

https://codereview.chromium.org/655783004/diff/1/cc/layers/scrollbar_layer_im...
File cc/layers/scrollbar_layer_impl_base.cc (right):

https://codereview.chromium.org/655783004/diff/1/cc/layers/scrollbar_layer_im...
cc/layers/scrollbar_layer_impl_base.cc:125: bool
ScrollbarLayerImplBase::can_scroll_orientation() const {
On 2014/10/15 15:39:52, danakj wrote:
> hacker_style functions should be for accessors, and defined in the header
file.
> If this is defined the .cc file it should NotBeHackerStyle.

Hi Dana, thank you for pointing this out. So far I have been somewhat confused
as some methods AreLikeThis() while others are_like_this(). Could you, please,
point me to the link that explains why is this, or explain it yourself? Is it
just whether the body appears in .h or .cc?

[danakj, 2014-10-15 18:13:26]

https://codereview.chromium.org/655783004/diff/1/cc/layers/scrollbar_layer_im...
File cc/layers/scrollbar_layer_impl_base.cc (right):

https://codereview.chromium.org/655783004/diff/1/cc/layers/scrollbar_layer_im...
cc/layers/scrollbar_layer_impl_base.cc:125: bool
ScrollbarLayerImplBase::can_scroll_orientation() const {
On 2014/10/15 18:12:05, timav wrote:
> On 2014/10/15 15:39:52, danakj wrote:
> > hacker_style functions should be for accessors, and defined in the header
> file.
> > If this is defined the .cc file it should NotBeHackerStyle.
> 
> Hi Dana, thank you for pointing this out. So far I have been somewhat confused
> as some methods AreLikeThis() while others are_like_this(). Could you, please,
> point me to the link that explains why is this, or explain it yourself? Is it
> just whether the body appears in .h or .cc?

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Names

[timav, 2014-10-15 19:05:13]

On 2014/10/15 18:13:26, danakj wrote:
>
https://codereview.chromium.org/655783004/diff/1/cc/layers/scrollbar_layer_im...
> File cc/layers/scrollbar_layer_impl_base.cc (right):
> 
>
https://codereview.chromium.org/655783004/diff/1/cc/layers/scrollbar_layer_im...
> cc/layers/scrollbar_layer_impl_base.cc:125: bool
> ScrollbarLayerImplBase::can_scroll_orientation() const {
> On 2014/10/15 18:12:05, timav wrote:
> > On 2014/10/15 15:39:52, danakj wrote:
> > > hacker_style functions should be for accessors, and defined in the header
> > file.
> > > If this is defined the .cc file it should NotBeHackerStyle.
> > 
> > Hi Dana, thank you for pointing this out. So far I have been somewhat
confused
> > as some methods AreLikeThis() while others are_like_this(). Could you,
please,
> > point me to the link that explains why is this, or explain it yourself? Is
it
> > just whether the body appears in .h or .cc?
> 
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Names

Done.

[timav, 2014-10-15 19:05:46]

The CQ bit was checked by timav@google.com

[commit-bot: I haz the power, 2014-10-15 19:07:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655783004/20001

[commit-bot: I haz the power, 2014-10-15 19:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-15 19:11:00]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/69020)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aelias_OOO_until_Jul13, 2014-10-15 19:18:12]

This already landed and the CQ has no concept of applying a diff like this, so
you can't recommit.  You'd have to make a separate change applying only the
style change.

[chromium-reviews, 2014-10-15 19:45:30]

Yes, I realized that reading why the patch did not apply.

On Wed, Oct 15, 2014 at 12:18 PM, <aelias@chromium.org> wrote:

> This already landed and the CQ has no concept of applying a diff like
> this, so
> you can't recommit.  You'd have to make a separate change applying only the
> style change.
>
> https://codereview.chromium.org/655783004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.