Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: chrome/browser/copresence/chrome_whispernet_client.h

Issue 637223011: Redesign the copresence audio handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/copresence/chrome_whispernet_client.cc » ('j') | components/copresence.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/copresence/chrome_whispernet_client.h
diff --git a/chrome/browser/copresence/chrome_whispernet_client.h b/chrome/browser/copresence/chrome_whispernet_client.h
index 4edcae5f7eb275e1c3a45dea9e42373ab59f2f52..9c0bd99761080c4a1bef1e9ef6d0ae142ec7d45f 100644
--- a/chrome/browser/copresence/chrome_whispernet_client.h
+++ b/chrome/browser/copresence/chrome_whispernet_client.h
@@ -10,6 +10,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "components/copresence/public/copresence_constants.h"
#include "components/copresence/public/whispernet_client.h"
namespace content {
@@ -30,7 +31,7 @@ class AudioBusRefCounted;
// This class is responsible for communication with our ledger_proxy extension
// that talks to the whispernet audio library.
-class ChromeWhispernetClient : public copresence::WhispernetClient {
+class ChromeWhispernetClient final : public copresence::WhispernetClient {
public:
// The browser context needs to outlive this class.
explicit ChromeWhispernetClient(content::BrowserContext* browser_context);
@@ -40,8 +41,10 @@ class ChromeWhispernetClient : public copresence::WhispernetClient {
virtual void Initialize(const SuccessCallback& init_callback) override;
Daniel Erat 2014/10/22 16:34:34 nit: i think that the latest is that 'virtual' is
rkc 2014/10/22 18:21:46 Ah they fixed the presubmit for this? I'll go ahea
Daniel Erat 2014/10/22 18:32:39 might want to double-check first; i'm just parrott
rkc 2014/10/22 19:28:46 Seems to be; someone also did a massive refactor c
virtual void Shutdown() override;
- virtual void EncodeToken(const std::string& token, bool audible) override;
- virtual void DecodeSamples(const std::string& samples) override;
+ virtual void EncodeToken(const std::string& token,
+ copresence::AudioType type) override;
+ virtual void DecodeSamples(copresence::AudioType type,
+ const std::string& samples) override;
virtual void DetectBroadcast() override;
virtual void RegisterTokensCallback(
« no previous file with comments | « no previous file | chrome/browser/copresence/chrome_whispernet_client.cc » ('j') | components/copresence.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698