Redesign the copresence audio handlers.

chrome/browser/copresence/chrome_whispernet_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COPRESENCE_CHROME_WHISPERNET_CLIENT_H_
 #define CHROME_BROWSER_COPRESENCE_CHROME_WHISPERNET_CLIENT_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
+#include "components/copresence/public/copresence_constants.h"
 #include "components/copresence/public/whispernet_client.h"
 
 namespace content {
 class BrowserContext;
 }
 
 namespace extensions {
 namespace api {
 namespace copresence_private {
 struct AudioParameters;
 }
 }
 }
 
 namespace media {
 class AudioBusRefCounted;
 }
 
 // This class is responsible for communication with our ledger_proxy extension
 // that talks to the whispernet audio library.
-class ChromeWhispernetClient : public copresence::WhispernetClient {
+class ChromeWhispernetClient final : public copresence::WhispernetClient {
  public:
   // The browser context needs to outlive this class.
   explicit ChromeWhispernetClient(content::BrowserContext* browser_context);
   virtual ~ChromeWhispernetClient();
 
   // WhispernetClient overrides:
   virtual void Initialize(const SuccessCallback& init_callback) override;

[Daniel Erat, 2014/10/22 16:34:34]

nit: i think that the latest is that 'virtual' is supposed to be omitted when
'override' is present

[rkc, 2014/10/22 18:21:46]

Ah they fixed the presubmit for this?
I'll go ahead and change it everywhere.

[Daniel Erat, 2014/10/22 18:32:39]

might want to double-check first; i'm just parrotting what i saw on another
review. :-P

[rkc, 2014/10/22 19:28:46]

Seems to be; someone also did a massive refactor changing this across the code
base.

   virtual void Shutdown() override;
 
-  virtual void EncodeToken(const std::string& token, bool audible) override;
-  virtual void DecodeSamples(const std::string& samples) override;
+  virtual void EncodeToken(const std::string& token,
+                           copresence::AudioType type) override;
+  virtual void DecodeSamples(copresence::AudioType type,
+                             const std::string& samples) override;
   virtual void DetectBroadcast() override;
 
   virtual void RegisterTokensCallback(
       const TokensCallback& tokens_callback) override;
   virtual void RegisterSamplesCallback(
       const SamplesCallback& samples_callback) override;
   virtual void RegisterDetectBroadcastCallback(
       const SuccessCallback& db_callback) override;
 
   virtual TokensCallback GetTokensCallback() override;
@@ skipping 20 matching lines @@
   TokensCallback tokens_callback_;
   SamplesCallback samples_callback_;
   SuccessCallback db_callback_;
 
   bool extension_loaded_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeWhispernetClient);
 };
 
 #endif  // CHROME_BROWSER_COPRESENCE_CHROME_WHISPERNET_CLIENT_H_