Issue 637223008: Use C++11 range-based loop in core/events

Issue 637223008: Use C++11 range-based loop in core/events (Closed)

Created:
6 years, 2 months ago by riju_

Modified:
6 years, 2 months ago

Reviewers:
Mike West

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Use C++11 range-based loop in core/events Improves code readabilty. Also use >> for > > in template BUG=none TEST=no layout test failures Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183891

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -64 lines)			Patch
M	Source/core/events/CompositionEvent.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/core/events/DOMWindowEventQueue.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/events/EventDispatcher.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/EventListenerMap.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/EventListenerMap.cpp	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/events/EventPath.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/events/EventPath.cpp	View	6 chunks	+22 lines, -25 lines	0 comments	Download
M	Source/core/events/EventSender.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/events/EventTarget.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/events/GenericEventQueue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/GenericEventQueue.cpp	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/events/ScopedEventQueue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/ScopedEventQueue.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/TreeScopeEventContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/TreeScopeEventContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Mike West

LGTM. Please add "and >>" to the CL description, as you're making those changes as ...

6 years, 2 months ago (2014-10-17 10:48:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637223008/1

6 years, 2 months ago (2014-10-17 15:03:46 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 15:08:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183891