Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: Source/core/events/EventListenerMap.cpp

Issue 637223008: Use C++11 range-based loop in core/events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/EventListenerMap.h ('k') | Source/core/events/EventPath.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventListenerMap.cpp
diff --git a/Source/core/events/EventListenerMap.cpp b/Source/core/events/EventListenerMap.cpp
index e2567ed420582b07d5626a5866fee54f51b69407..8211a8e69e40fccae9867bf0dba1b01d81b974b1 100644
--- a/Source/core/events/EventListenerMap.cpp
+++ b/Source/core/events/EventListenerMap.cpp
@@ -200,11 +200,11 @@ void EventListenerMap::removeFirstEventListenerCreatedFromMarkup(const AtomicStr
static void copyListenersNotCreatedFromMarkupToTarget(const AtomicString& eventType, EventListenerVector* listenerVector, EventTarget* target)
{
- for (size_t i = 0; i < listenerVector->size(); ++i) {
+ for (const auto& eventListener : *listenerVector) {
// Event listeners created from markup have already been transfered to the shadow tree during cloning.
- if ((*listenerVector)[i].listener->wasCreatedFromMarkup())
+ if (eventListener.listener->wasCreatedFromMarkup())
continue;
- target->addEventListener(eventType, (*listenerVector)[i].listener, (*listenerVector)[i].useCapture);
+ target->addEventListener(eventType, eventListener.listener, eventListener.useCapture);
}
}
@@ -212,19 +212,19 @@ void EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget(EventTarge
{
assertNoActiveIterators();
- for (unsigned i = 0; i < m_entries.size(); ++i)
- copyListenersNotCreatedFromMarkupToTarget(m_entries[i].first, m_entries[i].second.get(), target);
+ for (const auto& eventListener : m_entries)
+ copyListenersNotCreatedFromMarkupToTarget(eventListener.first, eventListener.second.get(), target);
}
EventListenerIterator::EventListenerIterator()
- : m_map(0)
+ : m_map(nullptr)
, m_entryIndex(0)
, m_index(0)
{
}
EventListenerIterator::EventListenerIterator(EventTarget* target)
- : m_map(0)
+ : m_map(nullptr)
, m_entryIndex(0)
, m_index(0)
{
« no previous file with comments | « Source/core/events/EventListenerMap.h ('k') | Source/core/events/EventPath.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698