Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: tools/telemetry/telemetry/unittest_util/page_test_test_case.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/unittest_util/page_test_test_case.py
diff --git a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py
index 567bf1ae122c295144ac735008ef4f740813bd2c..1239ac364a3181386e15340bfa5a49a71ea610e2 100644
--- a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py
+++ b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py
@@ -57,8 +57,6 @@ class PageTestTestCase(unittest.TestCase):
assert options
temp_parser = options.CreateParser()
page_runner.AddCommandLineArgs(temp_parser)
- measurement.AddCommandLineArgs(temp_parser)
- measurement.SetArgumentDefaults(temp_parser)
defaults = temp_parser.get_default_values()
for k, v in defaults.__dict__.items():
if hasattr(options, k):
@@ -71,7 +69,6 @@ class PageTestTestCase(unittest.TestCase):
options.suppress_gtest_report = True
options.output_trace_tag = None
page_runner.ProcessCommandLineArgs(temp_parser, options)
- measurement.ProcessCommandLineArgs(temp_parser, options)
results = results_options.CreateResults(EmptyMetadataForTest(), options)
page_runner.Run(measurement, ps, expectations, options, results)
return results

Powered by Google App Engine
This is Rietveld 408576698