Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: tools/telemetry/telemetry/page/record_wpr_unittest.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/record_wpr_unittest.py
diff --git a/tools/telemetry/telemetry/page/record_wpr_unittest.py b/tools/telemetry/telemetry/page/record_wpr_unittest.py
index 49cf7dcab74822c90ea903db38567e2d7db2a4c2..b88bfd89c94fa432d3b9c53df72deb5acd593664 100644
--- a/tools/telemetry/telemetry/page/record_wpr_unittest.py
+++ b/tools/telemetry/telemetry/page/record_wpr_unittest.py
@@ -49,10 +49,6 @@ class MockPageTest(page_test.PageTest):
self._action_name_to_run = "RunBaz"
self.func_calls = []
- @classmethod
- def AddCommandLineArgs(cls, parser):
- parser.add_option('--mock-page-test-option', action="store_true")
-
def WillNavigateToPage(self, page, tab):
self.func_calls.append('WillNavigateToPage')
@@ -79,7 +75,7 @@ class MockBenchmark(benchmark.Benchmark):
mock_page_set = None
@classmethod
- def AddTestCommandLineArgs(cls, group):
+ def AddBenchmarkCommandLineArgs(cls, group):
group.add_option('', '--mock-benchmark-url', action='store', type='string')
def CreatePageSet(self, options):
@@ -182,7 +178,6 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):
flags = [
'--page-repeat', '2',
'--mock-benchmark-url', self._url,
- '--mock-page-test-option',
]
wpr_recorder = record_wpr.WprRecorder(self._test_data_dir, MockBenchmark(),
flags)
@@ -190,8 +185,6 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):
self.assertEquals(2, wpr_recorder.options.page_repeat)
# benchmark command-line args
self.assertEquals(self._url, wpr_recorder.options.mock_benchmark_url)
- # benchmark's page_test command-line args
- self.assertTrue(wpr_recorder.options.mock_page_test_option)
# invalid command-line args
self.assertFalse(hasattr(wpr_recorder.options, 'not_a_real_option'))

Powered by Google App Engine
This is Rietveld 408576698