Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/perf/benchmarks/thread_times.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/thread_times.py
diff --git a/tools/perf/benchmarks/thread_times.py b/tools/perf/benchmarks/thread_times.py
index dc87920bebd321b2229f0a324976c80ec659ab8f..afd424650dfcd9b805715efdcd950fdab116c888 100644
--- a/tools/perf/benchmarks/thread_times.py
+++ b/tools/perf/benchmarks/thread_times.py
@@ -7,12 +7,20 @@ from measurements import thread_times
import page_sets
from telemetry import benchmark
+class _ThreadTimes(benchmark.Benchmark):
+ @classmethod
+ def AddBenchmarkCommandLineArgs(cls, parser):
+ parser.add_option('--report-silk-details', action='store_true',
+ help='Report details relevant to silk.')
+
+ def CreatePageTest(self, options):
+ return thread_times.ThreadTimes(options.report_silk_details)
+
@benchmark.Enabled('android')
-class ThreadTimesKeySilkCases(benchmark.Benchmark):
+class ThreadTimesKeySilkCases(_ThreadTimes):
"""Measures timeline metrics while performing smoothness action on key silk
cases."""
- test = thread_times.ThreadTimes
page_set = page_sets.KeySilkCasesPageSet
@@ -25,36 +33,32 @@ class LegacySilkBenchmark(ThreadTimesKeySilkCases):
@benchmark.Enabled('android')
-class ThreadTimesFastPathMobileSites(benchmark.Benchmark):
+class ThreadTimesFastPathMobileSites(_ThreadTimes):
"""Measures timeline metrics while performing smoothness action on
key mobile sites labeled with fast-path tag.
http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
- test = thread_times.ThreadTimes
page_set = page_sets.KeyMobileSitesPageSet
options = {'page_label_filter' : 'fastpath'}
@benchmark.Enabled('android')
-class ThreadTimesSimpleMobileSites(benchmark.Benchmark):
+class ThreadTimesSimpleMobileSites(_ThreadTimes):
"""Measures timeline metric using smoothness action on simple mobile sites
http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
- test = thread_times.ThreadTimes
page_set = page_sets.SimpleMobileSitesPageSet
-class ThreadTimesCompositorCases(benchmark.Benchmark):
+class ThreadTimesCompositorCases(_ThreadTimes):
"""Measures timeline metrics while performing smoothness action on
tough compositor cases, using software rasterization.
http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
- test = thread_times.ThreadTimes
page_set = page_sets.ToughCompositorCasesPageSet
def CustomizeBrowserOptions(self, options):
silk_flags.CustomizeBrowserOptionsForSoftwareRasterization(options)
@benchmark.Enabled('android')
-class ThreadTimesPolymer(benchmark.Benchmark):
+class ThreadTimesPolymer(_ThreadTimes):
"""Measures timeline metrics while performing smoothness action on
Polymer cases."""
- test = thread_times.ThreadTimes
page_set = page_sets.PolymerPageSet

Powered by Google App Engine
This is Rietveld 408576698