Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: tools/perf/benchmarks/startup.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/startup.py
diff --git a/tools/perf/benchmarks/startup.py b/tools/perf/benchmarks/startup.py
index a7a8b7c4256e9a3cfe45c74ced961754c902c08b..8f61587116cae517757488adf7ca95c7331eab0b 100644
--- a/tools/perf/benchmarks/startup.py
+++ b/tools/perf/benchmarks/startup.py
@@ -7,60 +7,56 @@ import page_sets
from telemetry import benchmark
+class _StartupCold(benchmark.Benchmark):
+ options = {'pageset_repeat': 5}
+
+ def CreatePageTest(self, options):
+ return startup.Startup(cold=True)
+
+
+class _StartupWarm(benchmark.Benchmark):
+ options = {'pageset_repeat': 20}
+
+ def CreatePageTest(self, options):
+ return startup.Startup(cold=False)
+
+
@benchmark.Enabled('has tabs')
@benchmark.Disabled('snowleopard') # crbug.com/336913
-class StartupColdBlankPage(benchmark.Benchmark):
+class StartupColdBlankPage(_StartupCold):
tag = 'cold'
- test = startup.Startup
page_set = page_sets.BlankPageSet
- options = {'cold': True,
- 'pageset_repeat': 5}
@benchmark.Enabled('has tabs')
-class StartupWarmBlankPage(benchmark.Benchmark):
+class StartupWarmBlankPage(_StartupWarm):
tag = 'warm'
- test = startup.Startup
page_set = page_sets.BlankPageSet
- options = {'warm': True,
- 'pageset_repeat': 20}
@benchmark.Disabled # crbug.com/336913
-class StartupColdTheme(benchmark.Benchmark):
+class StartupColdTheme(_StartupCold):
tag = 'theme_cold'
- test = startup.Startup
page_set = page_sets.BlankPageSet
generated_profile_archive = 'theme_profile.zip'
- options = {'cold': True,
- 'pageset_repeat': 5}
@benchmark.Disabled
-class StartupWarmTheme(benchmark.Benchmark):
+class StartupWarmTheme(_StartupWarm):
tag = 'theme_warm'
- test = startup.Startup
page_set = page_sets.BlankPageSet
generated_profile_archive = 'theme_profile.zip'
- options = {'warm': True,
- 'pageset_repeat': 20}
@benchmark.Disabled # crbug.com/336913
-class StartupColdManyExtensions(benchmark.Benchmark):
+class StartupColdManyExtensions(_StartupCold):
tag = 'many_extensions_cold'
- test = startup.Startup
page_set = page_sets.BlankPageSet
generated_profile_archive = 'many_extensions_profile.zip'
- options = {'cold': True,
- 'pageset_repeat': 5}
@benchmark.Disabled
-class StartupWarmManyExtensions(benchmark.Benchmark):
+class StartupWarmManyExtensions(_StartupWarm):
tag = 'many_extensions_warm'
- test = startup.Startup
page_set = page_sets.BlankPageSet
generated_profile_archive = 'many_extensions_profile.zip'
- options = {'warm': True,
- 'pageset_repeat': 20}

Powered by Google App Engine
This is Rietveld 408576698