tools/perf/benchmarks/benchmark_unittest.py - Issue 637153002: telemetry: Remove command line args from page test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_unittest.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/benchmark_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_unittest.py b/tools/perf/benchmarks/benchmark_unittest.py

index 476804ed536fc00f2d39ba93634411665ec7bc23..5079c9acb698f3bebbf7ecb14c7221620b23d01d 100644

--- a/tools/perf/benchmarks/benchmark_unittest.py

+++ b/tools/perf/benchmarks/benchmark_unittest.py

@@ -75,7 +75,7 @@ def load_tests(_, _2, _3):

benchmarks_dir, top_level_dir, benchmark_module.Benchmark,

pattern='*.py').values()

for benchmark in all_benchmarks:

- if benchmark.PageTestClass() not in all_measurements:

+ if hasattr(benchmark, 'test') and benchmark.test not in all_measurements:

# If the benchmark is not in measurements, then it is not composable.

# Ideally we'd like to test these as well, but the non-composable

# benchmarks are usually long-running benchmarks.