telemetry: Remove command line args from page test

tools/perf/benchmarks/rasterize_and_record_micro.py

Index: tools/perf/benchmarks/rasterize_and_record_micro.py
diff --git a/tools/perf/benchmarks/rasterize_and_record_micro.py b/tools/perf/benchmarks/rasterize_and_record_micro.py
index 4626435b70a4759afd68404c0aa823a8a8ca22ac..91b29e0d78b92dabb094a221f23cbe9d65325c28 100644
--- a/tools/perf/benchmarks/rasterize_and_record_micro.py
+++ b/tools/perf/benchmarks/rasterize_and_record_micro.py
@@ -7,39 +7,63 @@ import page_sets
 from telemetry import benchmark
 
 
+class _RasterizeAndRecordMicro(benchmark.Benchmark):
+  @classmethod
+  def AddCommandLineArgs(cls, parser):
+    parser.add_option('--start-wait-time', type='float',
+                      default=2,
+                      help='Wait time before the benchmark is started '
+                      '(must be long enought to load all content)')
+    parser.add_option('--rasterize-repeat', type='int',
+                      default=100,
+                      help='Repeat each raster this many times. Increase '
+                      'this value to reduce variance.')
+    parser.add_option('--record-repeat', type='int',
+                      default=100,
+                      help='Repeat each record this many times. Increase '
+                      'this value to reduce variance.')
+    parser.add_option('--timeout', type='int',
+                      default=120,
+                      help='The length of time to wait for the micro '
+                      'benchmark to finish, expressed in seconds.')
+    parser.add_option('--report-detailed-results',
+                      action='store_true',
+                      help='Whether to report additional detailed results.')

[chrishenry, 2014/10/15 18:26:09]

(Not blocking patch, just commenting)

Augh... Do we really need all of these command-line flags?

Maybe some of these should just be hard-coded constants that people can modify
if desired.

[ernstm, 2014/10/16 22:32:12]

There is no way to find out if anybody is still using those. Let's remove them
in a separate patch and see if anybody complains.

+
+  def CreatePageTest(self, options):
+    return rasterize_and_record_micro.RasterizeAndRecordMicro(
+        options.start_wait_time, options.rasterize_repeat,
+        options.record_repeat, options.timeout, options.report_detailed_results)
+
 # RasterizeAndRecord disabled on mac because of crbug.com/350684.
 # RasterizeAndRecord disabled on windows because of crbug.com/338057.
 @benchmark.Disabled('mac', 'win')
-class RasterizeAndRecordMicroTop25(benchmark.Benchmark):
+class RasterizeAndRecordMicroTop25(_RasterizeAndRecordMicro):
   """Measures rasterize and record performance on the top 25 web pages.
 
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
-  test = rasterize_and_record_micro.RasterizeAndRecordMicro
   page_set = page_sets.Top25PageSet
 
 
 @benchmark.Disabled('mac', 'win')
-class RasterizeAndRecordMicroKeyMobileSites(benchmark.Benchmark):
+class RasterizeAndRecordMicroKeyMobileSites(_RasterizeAndRecordMicro):
   """Measures rasterize and record performance on the key mobile sites.
 
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
-  test = rasterize_and_record_micro.RasterizeAndRecordMicro
   page_set = page_sets.KeyMobileSitesPageSet
 
 
 @benchmark.Disabled('mac', 'win')
-class RasterizeAndRecordMicroKeySilkCases(benchmark.Benchmark):
+class RasterizeAndRecordMicroKeySilkCases(_RasterizeAndRecordMicro):
   """Measures rasterize and record performance on the silk sites.
 
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
-  test = rasterize_and_record_micro.RasterizeAndRecordMicro
   page_set = page_sets.KeySilkCasesPageSet
 
 
 @benchmark.Enabled('android')
-class RasterizeAndRecordMicroPolymer(benchmark.Benchmark):
+class RasterizeAndRecordMicroPolymer(_RasterizeAndRecordMicro):
   """Measures rasterize and record performance on the Polymer cases.
 
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
-  test = rasterize_and_record_micro.RasterizeAndRecordMicro
   page_set = page_sets.PolymerPageSet