content/browser/frame_host/render_widget_host_view_guest.cc - Issue 637083002: Sets the default background color of inline signin and user manager to grey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 637083002: Sets the default background color of inline signin and user manager to grey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits fixed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_guest.h ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | content/public/browser/render_widget_host_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_guest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc

index 982958a839b8cf3266eb2b84e70e1160c8eebf07..af598a8384d6f4a24cabf62e9ae806386baa3953 100644

--- a/content/browser/frame_host/render_widget_host_view_guest.cc

+++ b/content/browser/frame_host/render_widget_host_view_guest.cc

@@ -354,14 +354,15 @@ void RenderWidgetHostViewGuest::CopyFromCompositingSurface(

guest_->CopyFromCompositingSurface(src_subrect, dst_size, callback);

}

-void RenderWidgetHostViewGuest::SetBackgroundOpaque(bool opaque) {

+void RenderWidgetHostViewGuest::SetBackgroundColor(SkColor color) {

// Content embedders can toggle opaque backgrounds through this API.

// We plumb the value here so that BrowserPlugin updates its compositing

// state in response to this change. We also want to preserve this flag

// after recovering from a crash so we let BrowserPluginGuest store it.

if (!guest_)

return;

- RenderWidgetHostViewBase::SetBackgroundOpaque(opaque);

+ RenderWidgetHostViewBase::SetBackgroundColor(color);

+ bool opaque = GetBackgroundOpaque();

host_->SetBackgroundOpaque(opaque);

guest_->SetContentsOpaque(opaque);

}