content/browser/android/content_view_core_impl.cc - Issue 637083002: Sets the default background color of inline signin and user manager to grey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 637083002: Sets the default background color of inline signin and user manager to grey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits fixed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/profiles/user_manager_view.cc ('k') | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | content/public/browser/render_widget_host_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 69449fb5db4c006a4e69bc9a574e69eeb8c9a6d1..cc5bcd7bf0f3d1575db10dd2a1ab70baf328d75c 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -1281,8 +1281,12 @@ jint ContentViewCoreImpl::GetCurrentRenderProcessId(JNIEnv* env, jobject obj) {

void ContentViewCoreImpl::SetBackgroundOpaque(JNIEnv* env, jobject jobj,

jboolean opaque) {

- if (GetRenderWidgetHostViewAndroid())

- GetRenderWidgetHostViewAndroid()->SetBackgroundOpaque(opaque);

+ if (GetRenderWidgetHostViewAndroid()) {

+ if (opaque)

+ GetRenderWidgetHostViewAndroid()->FillBackgroundWithDefaultColor();

+ else

+ GetRenderWidgetHostViewAndroid()->SetBackgroundColor(SK_ColorTRANSPARENT);

+ }

}

void ContentViewCoreImpl::RequestTextSurroundingSelection(