net/spdy/spdy_session_unittest.cc - Issue 637023002: Misc. cleanup, primarily removing unused locals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session_unittest.cc

Issue 637023002: Misc. cleanup, primarily removing unused locals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove macros.h change Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session_unittest.cc

diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc

index 938f6e545a1d1319106507d5ca4455dc946cf138..d2d91072bcced2c72add361c3774046dd8615a0a 100644

--- a/net/spdy/spdy_session_unittest.cc

+++ b/net/spdy/spdy_session_unittest.cc

@@ -885,7 +885,7 @@ TEST_P(SpdySessionTest, ClientPing) {

session->CheckPingStatus(before_ping_time);

EXPECT_EQ(0, session->pings_in_flight());

- EXPECT_GE(session->next_ping_id(), static_cast<uint32>(1));

+ EXPECT_GE(session->next_ping_id(), 1U);

EXPECT_FALSE(session->check_ping_status_pending());

EXPECT_GE(session->last_activity_time(), before_ping_time);

@@ -1302,7 +1302,7 @@ TEST_P(SpdySessionTest, FailedPing) {

// Send a PING frame.

session->WritePingFrame(1, false);

EXPECT_LT(0, session->pings_in_flight());

- EXPECT_GE(session->next_ping_id(), static_cast<uint32>(1));

+ EXPECT_GE(session->next_ping_id(), 1U);

EXPECT_TRUE(session->check_ping_status_pending());

// Assert session is not closed.