stop building/testing old x86 validator.

src/trusted/validator_ragel/build.scons

Index: src/trusted/validator_ragel/build.scons
diff --git a/src/trusted/validator_ragel/build.scons b/src/trusted/validator_ragel/build.scons
index a0bfe2f3468889d4e5c65f20de6de2b5b78fae43..04ac8677abcd29b81eebcb0947056be63b751a1d 100644
--- a/src/trusted/validator_ragel/build.scons
+++ b/src/trusted/validator_ragel/build.scons
@@ -338,28 +338,6 @@ if ragel_involved:
       SideEffect('check_validator', regular_instructions_test)
       dfacheckvalidator_tests.append(regular_instructions_test)
 

[Mark Seaborn, 2014/10/07 21:53:46]

Style nit: remove 1 empty line here (so that there's not two consecutive empty
lines inside a function)

[shyamsundarr, 2014/10/08 19:59:03]

Done.

-      env32 = env.Clone(BUILD_TARGET_NAME='x86-32')
-      env64 = env.Clone(BUILD_TARGET_NAME='x86-64')
-      old_ncval32 = env32.File('$STAGING_DIR/ncval$PROGSUFFIX')
-      old_ncval64 = env64.File('$STAGING_DIR/ncval$PROGSUFFIX')
-
-      regular_instructions_old_test = env.AutoDepsCommand(
-        'regular_instructions_old_test_x86_%s.out' % bitness,
-        ['${PYTHON}',
-         env.File('verify_regular_instructions_old.py'),

[Mark Seaborn, 2014/10/07 21:53:46]

This would be an appropriate change in which to also remove
verify_regular_instructions_old.py, since this file lives in validator_ragel (so
we might otherwise easily not notice that it has become dead code).

Also remove the mention of verify_regular_instructions_old.py (typo'd as
"instruction_old") from src/trusted/validator_ragel/docs/testing.html.

[shyamsundarr, 2014/10/08 19:59:03]

Done.

-         xml,
-         '--bitness', bitness,
-         '--gas', gas,
-         '--objdump', objdump,
-         '--validator_dll', validator_dll,
-         '--ncval32', old_ncval32,
-         '--ncval64', old_ncval64,
-         '--errors', '${TARGET}'])
-
-      # Never run exhaustive tests in parallel because they can take all CPU.
-      env.AlwaysBuild(regular_instructions_old_test)
-      SideEffect('check_validator', regular_instructions_old_test)
-      dfacheckvalidator_tests.append(regular_instructions_old_test)
 
     # There are three categories of protected files: validator files, generated
     # files (those of validator files that lie withing 'gen' directory) and