stop building/testing old x86 validator.

src/trusted/validator_ragel/build.scons

 # -*- python -*-
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import hashlib
 import os
 import platform
 import sys
@@ skipping 319 matching lines @@
          env.File('verify_regular_instructions.py'),
          xml,
          '--bitness', bitness,
          '--validator_dll', validator_dll,
          '--decoder_dll', decoder_dll])
 
       # Never run exhaustive tests in parallel because they can take all CPU.
       env.AlwaysBuild(regular_instructions_test)
       SideEffect('check_validator', regular_instructions_test)
       dfacheckvalidator_tests.append(regular_instructions_test)
 

[Mark Seaborn, 2014/10/07 21:53:46]

Style nit: remove 1 empty line here (so that there's not two consecutive empty
lines inside a function)

[shyamsundarr, 2014/10/08 19:59:03]

Done.

-      env32 = env.Clone(BUILD_TARGET_NAME='x86-32')
-      env64 = env.Clone(BUILD_TARGET_NAME='x86-64')
-      old_ncval32 = env32.File('$STAGING_DIR/ncval$PROGSUFFIX')
-      old_ncval64 = env64.File('$STAGING_DIR/ncval$PROGSUFFIX')
-
-      regular_instructions_old_test = env.AutoDepsCommand(
-        'regular_instructions_old_test_x86_%s.out' % bitness,
-        ['${PYTHON}',
-         env.File('verify_regular_instructions_old.py'),

[Mark Seaborn, 2014/10/07 21:53:46]

This would be an appropriate change in which to also remove
verify_regular_instructions_old.py, since this file lives in validator_ragel (so
we might otherwise easily not notice that it has become dead code).

Also remove the mention of verify_regular_instructions_old.py (typo'd as
"instruction_old") from src/trusted/validator_ragel/docs/testing.html.

[shyamsundarr, 2014/10/08 19:59:03]

Done.

-         xml,
-         '--bitness', bitness,
-         '--gas', gas,
-         '--objdump', objdump,
-         '--validator_dll', validator_dll,
-         '--ncval32', old_ncval32,
-         '--ncval64', old_ncval64,
-         '--errors', '${TARGET}'])
-
-      # Never run exhaustive tests in parallel because they can take all CPU.
-      env.AlwaysBuild(regular_instructions_old_test)
-      SideEffect('check_validator', regular_instructions_old_test)
-      dfacheckvalidator_tests.append(regular_instructions_old_test)
 
     # There are three categories of protected files: validator files, generated
     # files (those of validator files that lie withing 'gen' directory) and
     # generating files (programs and input data used to produce generated
     # files).
     #
     # When validator files are changed, exhaustive validator tests have to be
     # rerun.  When generating files are changed, dfagen must be run to ensure
     # that generated files are up to date. Presubmit script uses
     # protected_files.json to perform these checks.
@@ skipping 118 matching lines @@
 
   if env.Bit('regenerate_golden'):
     # Don't want these tests run in parallel because they write
     # to .test files.
     SideEffect(tests_mask, spec_test)
 
     # Spec test uses @dis section in test files, which in turn is updated
     # by dis_section_test.
     if env.Bit('target_x86'):
       env.Depends(spec_test, dis_section_test)