Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 636933002: [MAC] Disable 'Import' button when visible checkboxes are unchecked. (Closed)

Created:
6 years, 2 months ago by Gaja
Modified:
6 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[MAC] Disable 'Import' button when visible checkboxes are unchecked. In "Import bookmarks and settings" overlay, 'Import' button is disabled when no checkboxes are checked. But for 'Safari' only 2 checkboxes are shown; when other checkboxes are checked in background(not shown), it causes the button to always be enabled regardless of visible checkboxes checked or unchecked. This CL checks if a checkbox is both shown and checked, to enable the button. BUG=275265 R=dbeam@chromium.org TEST= 1.Launch chrome ,go to settings and click on 'Import bookmarks and settings' button under 'Users' section. 2.Select 'Safari' and Uncheck 'Browsing history' and 'Favorites/Bookmarks' option . 3.Observe the 'Import' button. The 'Import' button should be disabled. Committed: https://crrev.com/ca595a12817b4855b2eb58a038b771d0bc76f664 Cr-Commit-Position: refs/heads/master@{#299840}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Changes with respect to comments. #

Total comments: 2

Patch Set 3 : Addressing reviewer's comments. #

Total comments: 4

Patch Set 4 : Comments addressed. Using .hidden property in place of style.display #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/browser/resources/options/import_data_overlay.js View 1 2 3 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (3 generated)
Gaja
@dbeam Please take a look. Thanks.
6 years, 2 months ago (2014-10-07 13:39:49 UTC) #1
Dan Beam
https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js File chrome/browser/resources/options/import_data_overlay.js (right): https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js#newcode78 chrome/browser/resources/options/import_data_overlay.js:78: ($('import-history-with-label').style.display != 'none' && i think asking the checkbox ...
6 years, 2 months ago (2014-10-07 17:05:15 UTC) #2
Gaja
Dan, Please review. Comments addressed in patch set #2. https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js File chrome/browser/resources/options/import_data_overlay.js (right): https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js#newcode78 chrome/browser/resources/options/import_data_overlay.js:78: ...
6 years, 2 months ago (2014-10-08 04:50:07 UTC) #3
Gaja
https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js File chrome/browser/resources/options/import_data_overlay.js (right): https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js#newcode78 chrome/browser/resources/options/import_data_overlay.js:78: ($('import-history-with-label').style.display != 'none' && On 2014/10/07 17:05:15, Dan Beam ...
6 years, 2 months ago (2014-10-08 05:02:48 UTC) #4
Dan Beam
lookin' pretty good https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js File chrome/browser/resources/options/import_data_overlay.js (right): https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js#newcode78 chrome/browser/resources/options/import_data_overlay.js:78: ($('import-history-with-label').style.display != 'none' && On 2014/10/08 ...
6 years, 2 months ago (2014-10-08 21:36:23 UTC) #5
Gaja
@dbeam, Comments addressed in Patch Set #3. Please take a look. Thanks. https://codereview.chromium.org/636933002/diff/1/chrome/browser/resources/options/import_data_overlay.js File chrome/browser/resources/options/import_data_overlay.js ...
6 years, 2 months ago (2014-10-10 05:19:30 UTC) #6
Dan Beam
why wouldn't we just do this? https://codereview.chromium.org/648833002/diff/30001/chrome/browser/resources/options/import_data_overlay.js
6 years, 2 months ago (2014-10-10 19:28:31 UTC) #7
Gaja
On 2014/10/10 19:28:31, Dan Beam wrote: > why wouldn't we just do this? > https://codereview.chromium.org/648833002/diff/30001/chrome/browser/resources/options/import_data_overlay.js ...
6 years, 2 months ago (2014-10-11 04:27:45 UTC) #8
Gaja
Dan, Please take a look.
6 years, 2 months ago (2014-10-14 17:22:59 UTC) #9
Dan Beam
https://codereview.chromium.org/636933002/diff/40001/chrome/browser/resources/options/import_data_overlay.js File chrome/browser/resources/options/import_data_overlay.js (right): https://codereview.chromium.org/636933002/diff/40001/chrome/browser/resources/options/import_data_overlay.js#newcode29 chrome/browser/resources/options/import_data_overlay.js:29: getComputedStyle($(el + '-with-label')).display != 'none'; fine, but use hidden ...
6 years, 2 months ago (2014-10-15 03:41:36 UTC) #10
Gaja
Dan, Comments addressed in Patch Set #4. Please take a look. https://codereview.chromium.org/636933002/diff/40001/chrome/browser/resources/options/import_data_overlay.js File chrome/browser/resources/options/import_data_overlay.js (right): ...
6 years, 2 months ago (2014-10-15 05:10:51 UTC) #11
Dan Beam
lgtm i'll address a related issue here: https://codereview.chromium.org/660623002/
6 years, 2 months ago (2014-10-15 19:28:37 UTC) #12
Gaja
On 2014/10/15 19:28:37, Dan Beam wrote: > lgtm > > i'll address a related issue ...
6 years, 2 months ago (2014-10-16 02:34:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636933002/100001
6 years, 2 months ago (2014-10-16 02:35:54 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/22636)
6 years, 2 months ago (2014-10-16 03:57:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636933002/100001
6 years, 2 months ago (2014-10-16 04:00:24 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:100001)
6 years, 2 months ago (2014-10-16 04:34:06 UTC) #20
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 04:35:03 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ca595a12817b4855b2eb58a038b771d0bc76f664
Cr-Commit-Position: refs/heads/master@{#299840}

Powered by Google App Engine
This is Rietveld 408576698