Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 636803003: Add the chromium android linker to APK dependencies. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add the chromium android linker to APK dependencies. libchromium_android_linker.so changes do not currently trigger an APK rebuild. Hoisting a dependency fixes this. BUG= Committed: https://crrev.com/90384e880b17542882508761937a7751252322c7 Cr-Commit-Position: refs/heads/master@{#298470}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M build/java_apk.gypi View 2 chunks +15 lines, -15 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-07 11:18:34 UTC) #2
Andrew Hayden (chromium.org)
https://codereview.chromium.org/636803003/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/636803003/diff/1/build/java_apk.gypi#newcode226 build/java_apk.gypi:226: 'chromium_linker_path': [ I am hopeful that this can just ...
6 years, 2 months ago (2014-10-07 11:28:19 UTC) #3
Andrew Hayden (chromium.org)
On 2014/10/07 11:28:19, Andrew Hayden wrote: > https://codereview.chromium.org/636803003/diff/1/build/java_apk.gypi > File build/java_apk.gypi (right): > > https://codereview.chromium.org/636803003/diff/1/build/java_apk.gypi#newcode226 ...
6 years, 2 months ago (2014-10-07 11:37:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636803003/1
6 years, 2 months ago (2014-10-07 13:06:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1b59b3a67542e570136b3ac7111137097a771994
6 years, 2 months ago (2014-10-07 14:18:13 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:19:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90384e880b17542882508761937a7751252322c7
Cr-Commit-Position: refs/heads/master@{#298470}

Powered by Google App Engine
This is Rietveld 408576698