Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: build/java_apk.gypi

Issue 636803003: Add the chromium android linker to APK dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index 1b90a1b4b6e2dea69c49c41282e7327f7e7683b5..52f4ab5eb91be7ee579abf94a81d60d1065123af 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -220,9 +220,23 @@
}],
['native_lib_target != ""', {
'variables': {
+ 'conditions': [
+ ['use_chromium_linker == 1', {
+ 'variables': {
+ 'chromium_linker_path': [
Andrew Hayden (chromium.org) 2014/10/07 11:28:19 I am hopeful that this can just be a string argume
+ '<(SHARED_LIB_DIR)/<(libchromium_android_linker)',
+ ],
+ }
+ }, {
+ 'variables': {
+ 'chromium_linker_path': [],
+ },
+ }],
+ ],
'generated_src_dirs': [ '<(native_libraries_java_dir)' ],
'native_libs_paths': [
- '<(SHARED_LIB_DIR)/<(native_lib_target).>(android_product_extension)'
+ '<(SHARED_LIB_DIR)/<(native_lib_target).>(android_product_extension)',
+ '<@(chromium_linker_path)'
],
'package_input_paths': [
'<(apk_package_native_libs_dir)/<(android_app_abi)/gdbserver',
@@ -242,23 +256,9 @@
'actions': [
{
'variables': {
- 'conditions': [
- ['use_chromium_linker == 1', {
- 'variables': {
- 'linker_input_libraries': [
- '<(SHARED_LIB_DIR)/<(libchromium_android_linker)',
- ],
- }
- }, {
- 'variables': {
- 'linker_input_libraries': [],
- },
- }],
- ],
'input_libraries': [
'<@(native_libs_paths)',
'<@(extra_native_libs)',
- '<@(linker_input_libraries)',
],
},
'includes': ['../build/android/write_ordered_libraries.gypi'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698