Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 63673004: [Files.app] Make the file-type dropbox at the bottom hidden by default (Closed)

Created:
7 years, 1 month ago by yoshiki
Modified:
7 years, 1 month ago
Reviewers:
mtomasz, hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Files.app] Make the file-type dropbox at the bottom hidden by default This is a reland of r233875. The previous patch didn't make the dropbox hidden in the open dialog. This patch adds change it as well as the save-as dialog. BUG=316133 TEST=manually tested R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234982

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 chunk +6 lines, -7 lines 1 comment Download
M chrome/browser/resources/file_manager/main.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
@hirono, PTAL. Sorry for your double works. Thanks.
7 years, 1 month ago (2013-11-12 20:41:46 UTC) #1
hirono
lgtm! Thanks!
7 years, 1 month ago (2013-11-12 20:53:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/63673004/1
7 years, 1 month ago (2013-11-12 20:57:17 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 21:52:43 UTC) #4
yoshiki
Committed patchset #1 manually as r234982 (presubmit successful).
7 years, 1 month ago (2013-11-14 00:37:23 UTC) #5
mtomasz
7 years, 1 month ago (2013-11-21 04:24:10 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/63673004/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/foreground/js/file_manager.js
(right):

https://codereview.chromium.org/63673004/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/foreground/js/file_manager.js:1315: //
There is in fact no choice, show the selector.
Please fix this comment, it is wrong.

Powered by Google App Engine
This is Rietveld 408576698