Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: chrome/browser/resources/file_manager/foreground/js/file_manager.js

Issue 63673004: [Files.app] Make the file-type dropbox at the bottom hidden by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/foreground/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/foreground/js/file_manager.js b/chrome/browser/resources/file_manager/foreground/js/file_manager.js
index a3bba825bdc50c5048c3eb2e6cf4c8cfd20cee4e..9a2dc8178f9e2369d7a65c3ba1a0fc3b22f32475 100644
--- a/chrome/browser/resources/file_manager/foreground/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/foreground/js/file_manager.js
@@ -1311,14 +1311,13 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
}
var options = this.fileTypeSelector_.querySelectorAll('option');
- if (options.length < 2) {
- // There is in fact no choice, hide the selector.
- this.fileTypeSelector_.hidden = true;
- return;
- }
+ if (options.length >= 2) {
+ // There is in fact no choice, show the selector.
mtomasz 2013/11/21 04:24:11 Please fix this comment, it is wrong.
+ this.fileTypeSelector_.hidden = false;
- this.fileTypeSelector_.addEventListener('change',
- this.updateFileTypeFilter_.bind(this));
+ this.fileTypeSelector_.addEventListener('change',
+ this.updateFileTypeFilter_.bind(this));
+ }
};
/**
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698