Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 636673002: Remove navigation from TestRenderViewHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes from self-review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index 0dc0bc9788db3e5971218142c5380f718e4aeaf5..9220f4f8cffd4e1ae63cb301200e97793e731ec3 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -281,11 +281,10 @@ class RenderFrameHostManagerTest
// for us.
controller().LoadURL(
url, Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
- TestRenderViewHost* old_rvh = test_rvh();
- TestRenderFrameHost* old_rfh = main_test_rfh();
- TestRenderFrameHost* active_rfh = pending_main_rfh() ?
- static_cast<TestRenderFrameHost*>(pending_main_rfh()) :
- old_rfh;
+ TestRenderFrameHost* old_rfh = contents()->GetMainFrame();
+ TestRenderFrameHost* active_rfh = contents()->GetPendingMainFrame()
+ ? contents()->GetPendingMainFrame()
+ : old_rfh;
// Simulate the BeforeUnload_ACK that is received from the current renderer
// for a cross-site navigation.
@@ -301,7 +300,7 @@ class RenderFrameHostManagerTest
// Use an observer to avoid accessing a deleted renderer later on when the
// state is being checked.
RenderFrameHostDeletedObserver rfh_observer(old_rfh);
- RenderViewHostDeletedObserver rvh_observer(old_rvh);
+ RenderViewHostDeletedObserver rvh_observer(old_rfh->GetRenderViewHost());
active_rfh->SendNavigate(max_page_id + 1, url);
// Make sure that we start to run the unload handler at the time of commit.

Powered by Google App Engine
This is Rietveld 408576698