content/browser/renderer_host/render_view_host_unittest.cc - Issue 636673002: Remove navigation from TestRenderViewHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_unittest.cc

Issue 636673002: Remove navigation from TestRenderViewHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes from self-review Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_view_host_unittest.cc

diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc

index be0a1d8755ab47d6845fbb4ca7aeafeb7928e1cc..c67aff3c4044292a2ba146622cd4a2f70c159dbc 100644

--- a/content/browser/renderer_host/render_view_host_unittest.cc

+++ b/content/browser/renderer_host/render_view_host_unittest.cc

@@ -64,7 +64,7 @@ class RenderViewHostTest : public RenderViewHostImplTestHarness {

// All about URLs reported by the renderer should get rewritten to about:blank.

// See RenderViewHost::OnNavigate for a discussion.

TEST_F(RenderViewHostTest, FilterAbout) {

- test_rvh()->SendNavigate(1, GURL("about:cache"));

+ contents()->GetMainFrame()->SendNavigate(1, GURL("about:cache"));

ASSERT_TRUE(controller().GetVisibleEntry());

EXPECT_EQ(GURL(url::kAboutBlankURL),

controller().GetVisibleEntry()->GetURL());