Remove navigation from TestRenderViewHost

Remove all navigation methods from TestRenderViewHost, RenderViewHostTester.
Use the versions on TestRenderFrameHost instead.

BUG=304341
TEST=unit_tests, content_unittests
TBR=phajdan.jr@chromium.org, mvanouwerkerk@chromium.org

Committed: https://crrev.com/31074213945662069d35fe9b9c3744d0c7ec9c01
Cr-Commit-Position: refs/heads/master@{#298983}

[ncarter (slow), 2014-10-07 01:13:59]

nick@chromium.org changed reviewers:
+ creis@chromium.org

[ncarter (slow), 2014-10-07 01:14:00]

Charlie: Please review

[ncarter (slow), 2014-10-08 17:13:56]

creis: ping

[Charlie Reis, 2014-10-08 17:41:55]

Sorry for the delay.  So glad to see these going away from TRVH!

A few minor questions below.

https://codereview.chromium.org/636673002/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
(right):

https://codereview.chromium.org/636673002/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/client_side_detection_host_unittest.cc:989:
RenderFrameHostTester::For(web_contents()->GetMainFrame())->
Why are some of these using main_rfh() and others using
web_contents()->GetMainFrame()?

https://codereview.chromium.org/636673002/diff/20001/content/browser/frame_ho...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/636673002/diff/20001/content/browser/frame_ho...
content/browser/frame_host/navigation_controller_impl_unittest.cc:4249:
contents()->GetMainFrame()->SendNavigate(1, GURL("http://foo"));
Again, why choose this over main_rfh() in some places but not others?

https://codereview.chromium.org/636673002/diff/20001/content/browser/frame_ho...
File content/browser/frame_host/render_frame_host_manager_unittest.cc (right):

https://codereview.chromium.org/636673002/diff/20001/content/browser/frame_ho...
content/browser/frame_host/render_frame_host_manager_unittest.cc:330: }
Were you going to confirm that active_rfh is the current RFH, and that there's
no pending RFH at this point?

https://codereview.chromium.org/636673002/diff/20001/content/test/test_render...
File content/test/test_render_view_host.h (right):

https://codereview.chromium.org/636673002/diff/20001/content/test/test_render...
content/test/test_render_view_host.h:222: void
SendNavigateWithOriginalRequestURL(
Are these going away in a future CL?

[ncarter (slow), 2014-10-08 22:39:28]

PTAL

https://codereview.chromium.org/636673002/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
(right):

https://codereview.chromium.org/636673002/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/client_side_detection_host_unittest.cc:989:
RenderFrameHostTester::For(web_contents()->GetMainFrame())->
On 2014/10/08 17:41:55, Charlie Reis wrote:
> Why are some of these using main_rfh() and others using
> web_contents()->GetMainFrame()?

Done. I've switched these over to be web_contents()->GetMainFrame() except when
the surrounding test code already uses main_rfh(), in which case I'm consistent
with that.

I prefer contents()->GetMainFrame() generally.

https://codereview.chromium.org/636673002/diff/20001/content/browser/frame_ho...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/636673002/diff/20001/content/browser/frame_ho...
content/browser/frame_host/navigation_controller_impl_unittest.cc:4249:
contents()->GetMainFrame()->SendNavigate(1, GURL("http://foo"));
On 2014/10/08 17:41:55, Charlie Reis wrote:
> Again, why choose this over main_rfh() in some places but not others?

Discussed in previous comment.

https://codereview.chromium.org/636673002/diff/20001/content/browser/frame_ho...
File content/browser/frame_host/render_frame_host_manager_unittest.cc (right):

https://codereview.chromium.org/636673002/diff/20001/content/browser/frame_ho...
content/browser/frame_host/render_frame_host_manager_unittest.cc:330: }
On 2014/10/08 17:41:55, Charlie Reis wrote:
> Were you going to confirm that active_rfh is the current RFH, and that there's
> no pending RFH at this point?

Done.

https://codereview.chromium.org/636673002/diff/20001/content/test/test_render...
File content/test/test_render_view_host.h (right):

https://codereview.chromium.org/636673002/diff/20001/content/test/test_render...
content/test/test_render_view_host.h:222: void
SendNavigateWithOriginalRequestURL(
On 2014/10/08 17:41:55, Charlie Reis wrote:
> Are these going away in a future CL?

Whoops! I meant to rip these out too!

The new patch set eliminates seven more methods and a couple of data members.

[Charlie Reis, 2014-10-08 23:45:02]

Great.  LGTM!

[ncarter (slow), 2014-10-09 17:32:05]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2014-10-09 17:32:11]

The CQ bit was unchecked by nick@chromium.org

[ncarter (slow), 2014-10-09 17:37:10]

nick@chromium.org changed reviewers:
+ droger@chromium.org, noelutz@google.com, phajdan.jr@chromium.org,
timvolodine@chromium.org

[ncarter (slow), 2014-10-09 17:37:11]

noelutz@google.com: Please review changes in
chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

droger@chromium.org: Please review changes in
chrome/browser/translate/translate_manager_render_view_host_unittest.cc

timvolodine@chromium.org: Please review changes in
chrome/browser/geolocation/geolocation_permission_context_unittest.cc

phajdan.jr@chromium.org: Please review changes in chrome/test/...

[droger, 2014-10-09 17:42:23]

Translate Lgtm

[noé, 2014-10-09 20:20:56]

noelutz@chromium.org changed reviewers:
+ noelutz@chromium.org

[noé, 2014-10-09 20:20:57]

lgtm

[ncarter (slow), 2014-10-09 20:24:22]

nick@chromium.org changed reviewers:
- noelutz@google.com, timvolodine@chromium.org

[ncarter (slow), 2014-10-09 20:26:18]

nick@chromium.org changed reviewers:
+ mattm@chromium.org

[ncarter (slow), 2014-10-09 20:26:19]

mattm@chromium.org: Please review changes in
chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

[ncarter (slow), 2014-10-09 20:28:13]

nick@chromium.org changed reviewers:
- mattm@chromium.org

[ncarter (slow), 2014-10-09 20:28:14]

-mattm, nevermind -- I have noe's lgtm, was confused.

[ncarter (slow), 2014-10-09 20:29:07]

nick@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[ncarter (slow), 2014-10-09 20:29:08]

mvanouwerkerk@chromium.org: Please review changes in
chrome/browser/geolocation/geolocation_permission_context_unittest.cc

[ncarter (slow), 2014-10-09 21:17:54]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2014-10-09 21:20:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/636673002/60001

[commit-bot: I haz the power, 2014-10-09 21:36:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-09 21:36:49]

Patchset 4 (id:??) landed as
https://crrev.com/31074213945662069d35fe9b9c3744d0c7ec9c01
Cr-Commit-Position: refs/heads/master@{#298983}