chrome/browser/ssl/ssl_browser_tests.cc - Issue 636673002: Remove navigation from TestRenderViewHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 636673002: Remove navigation from TestRenderViewHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a TODO Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 569a570c9861136b14b4de3e8655f5c4dfaf3fc4..6cce4ccb046fc99f4119513de6b8150c0ed13242 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -560,6 +560,8 @@ IN_PROC_BROWSER_TEST_F(SSLUITest,

// Wait until we hear the load failure, and make sure we haven't swapped out

// the previous page. Prevents regression of http://crbug.com/82667.

+ // TODO(creis/nick): Move the swapped-out part of this test into content

+ // and remove IsRenderViewHostSwappedOut from the public API.

load_failed_observer.Wait();

EXPECT_FALSE(content::RenderViewHostTester::IsRenderViewHostSwappedOut(

tab->GetRenderViewHost()));