mojo/mojo_services.gypi - Issue 636363002: Splits window manager like methods into ViewManagerServiceDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/mojo_services.gypi

Issue 636363002: Splits window manager like methods into ViewManagerServiceDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/examples/wm_flow/wm/wm.cc ('k') | mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h » ('j') | mojo/services/public/interfaces/window_manager/window_manager.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/mojo_services.gypi

diff --git a/mojo/mojo_services.gypi b/mojo/mojo_services.gypi

index e4f5b2007f4bb18fcccb0168318c6e371a34eac6..1eacdbec36d890009567728782527598a1ef4c1e 100644

--- a/mojo/mojo_services.gypi

+++ b/mojo/mojo_services.gypi

@@ -421,7 +421,6 @@

'services/public/cpp/view_manager/view_manager_context.h',

'services/public/cpp/view_manager/view_manager_delegate.h',

'services/public/cpp/view_manager/view_observer.h',

- 'services/public/cpp/view_manager/window_manager_delegate.h',

'export_dependent_settings': [

'services/public/mojo_services_public.gyp:mojo_view_manager_bindings',

@@ -519,6 +518,7 @@

'services/public/mojo_services_public.gyp:mojo_surfaces_bindings',

'services/public/mojo_services_public.gyp:mojo_view_manager_bindings',

'services/public/mojo_services_public.gyp:mojo_view_manager_common',

+ 'services/public/mojo_services_public.gyp:mojo_window_manager_bindings',

'<(mojo_system_for_loadable_module)',

'sources': [

@@ -544,6 +544,8 @@

'services/view_manager/view_manager_service_impl.h',

'services/view_manager/window_manager_access_policy.cc',

'services/view_manager/window_manager_access_policy.h',

+ 'services/view_manager/window_manager_client_impl.cc',

+ 'services/view_manager/window_manager_client_impl.h',

'includes': [

'mojo_public_gles2_for_loadable_module.gypi',

@@ -574,6 +576,7 @@

'services/public/mojo_services_public.gyp:mojo_input_events_bindings',

'services/public/mojo_services_public.gyp:mojo_view_manager_bindings',

'services/public/mojo_services_public.gyp:mojo_view_manager_common',

+ 'services/public/mojo_services_public.gyp:mojo_window_manager_bindings',

# Included only to force deps for bots.

'mojo_native_viewport_service',

'mojo_surfaces_service',

@@ -614,13 +617,18 @@

'mojo_base.gyp:mojo_common_lib',

'mojo_input_events_lib',

'mojo_view_manager_lib',

+ 'public/mojo_public.gyp:mojo_application_bindings',

'services/public/mojo_services_public.gyp:mojo_core_window_manager_bindings',

+ 'services/public/mojo_services_public.gyp:mojo_window_manager_bindings',

'sources': [

'services/window_manager/window_manager_app.cc',

'services/window_manager/window_manager_app.h',

+ 'services/window_manager/window_manager_delegate.h',

'services/window_manager/window_manager_service_impl.cc',

'services/window_manager/window_manager_service_impl.h',

+ 'services/window_manager/window_manager_service2_impl.cc',

+ 'services/window_manager/window_manager_service2_impl.h',

{