mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h - Issue 636363002: Splits window manager like methods into ViewManagerServiceDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

Issue 636363002: Splits window manager like methods into ViewManagerServiceDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor cleanup Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/mojo_services.gypi ('k') | mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc » ('j') | mojo/services/public/interfaces/view_manager/view_manager_service_delegate.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

index e2dab1da0334db96df2a7e51e44bd24f69aef72c..5f364b5e66245f57a1aba7e77cdd15c30c8e0708 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

@@ -77,9 +77,6 @@ class ViewManagerClientImpl : public ViewManager,

typedef std::map<Id, View*> IdToViewMap;

// Overridden from ViewManager:

- virtual void SetWindowManagerDelegate(

- WindowManagerDelegate* delegate) override;

- virtual void DispatchEvent(View* target, EventPtr event) override;

virtual const std::string& GetEmbedderURL() const override;

virtual const std::vector<View*>& GetRoots() const override;

virtual View* GetViewById(Id id) override;

@@ -108,10 +105,6 @@ class ViewManagerClientImpl : public ViewManager,

virtual void OnViewInputEvent(Id view_id,

EventPtr event,

const Callback<void()>& callback) override;

- virtual void Embed(

- const String& url,

- InterfaceRequest<ServiceProvider> service_provider) override;

- virtual void DispatchOnViewInputEvent(EventPtr event) override;

// Overridden from WindowManagerClient:

virtual void OnWindowManagerReady() override;

@@ -139,7 +132,6 @@ class ViewManagerClientImpl : public ViewManager,

base::Callback<void(void)> change_acked_callback_;

ViewManagerDelegate* delegate_;

- WindowManagerDelegate* window_manager_delegate_;

std::vector<View*> roots_;