Issue 636313003: Fix uninitialized FixedArray potentially being left behind by ElementsTransitionGenerator::Generate…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 636313003: Fix uninitialized FixedArray potentially being left behind by ElementsTransitionGenerator::Generate… (Closed)

Created:
6 years, 2 months ago by Jakob Kummerow

Modified:
6 years, 2 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix uninitialized FixedArray potentially being left behind by ElementsTransitionGenerator::GenerateDoubleToObject BUG=chromium:421843 LOG=n R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24498

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -5 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 chunk	+15 lines, -1 line	0 comments	Download
M	src/arm64/codegen-arm64.cc	View	1 chunk	+16 lines, -3 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/runtime/runtime-test.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Jakob Kummerow

PTAL. I would have added a regression test, but it's very sensitive to GC timing, ...

6 years, 2 months ago (2014-10-09 12:11:29 UTC) #2

Jakob Kummerow

6 years, 2 months ago (2014-10-09 14:12:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24498 (presubmit successful).