src/runtime/runtime-test.cc - Issue 636313003: Fix uninitialized FixedArray potentially being left behind by ElementsTransitionGenerator::Generate…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-test.cc

Issue 636313003: Fix uninitialized FixedArray potentially being left behind by ElementsTransitionGenerator::Generate… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-test.cc

diff --git a/src/runtime/runtime-test.cc b/src/runtime/runtime-test.cc

index 67c68b7f4c148f7cb608e2cfe25765e453c669d2..095d97fb751ec7ee342fca5757cb49e9672fd943 100644

--- a/src/runtime/runtime-test.cc

+++ b/src/runtime/runtime-test.cc

@@ -247,7 +247,9 @@ RUNTIME_FUNCTION(Runtime_GlobalPrint) {

RUNTIME_FUNCTION(Runtime_SystemBreak) {

- SealHandleScope shs(isolate);

+ // The code below doesn't create handles, but when breaking here in GDB

+ // having a handle scope might be useful.

+ HandleScope scope(isolate);

DCHECK(args.length() == 0);

base::OS::DebugBreak();

return isolate->heap()->undefined_value();

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »