Remove WebPoint version of WebLayerImpl::setScrollPosition

Remove WebPoint version of WebLayerImpl::setScrollPosition

Now that blink side interface WebLayer::setScrollPosition
has changed to use WebDoublePoint version, we can remove
the WebPoint version in WebLayerImpl.

BUG=414283
Committed: https://crrev.com/d2061d67be46908bb069329c9278a98ad39fc8cb
Cr-Commit-Position: refs/heads/master@{#299120}

[Yufeng Shen (Slow to review), 2014-10-09 20:09:45]

miletus@chromium.org changed reviewers:
+ danakj@chromium.org

[Yufeng Shen (Slow to review), 2014-10-09 20:10:09]

This is pending on landing
https://codereview.chromium.org/629583002/

[danakj, 2014-10-09 20:11:17]

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.cc
File cc/blink/web_layer_impl.cc (right):

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.cc#n...
cc/blink/web_layer_impl.cc:437: void AppendAsTraceFormat(std::string* out) const
override {
ditto?

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h
File cc/blink/web_layer_impl.h (right):

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h#ne...
cc/blink/web_layer_impl.h:135:
scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo() override;
i think clang plugin still complains about virtual with no override? anyhow this
is not related to this CL right?

[Yufeng Shen (Slow to review), 2014-10-09 20:13:02]

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h
File cc/blink/web_layer_impl.h (right):

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h#ne...
cc/blink/web_layer_impl.h:135:
scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo() override;
On 2014/10/09 20:11:17, danakj wrote:
> i think clang plugin still complains about virtual with no override? anyhow
this
> is not related to this CL right?

Yeah, presubmit complains about it so I thought I just fix it here.
Is the complain actually wrong ?

[danakj, 2014-10-09 20:14:12]

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h
File cc/blink/web_layer_impl.h (right):

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h#ne...
cc/blink/web_layer_impl.h:135:
scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo() override;
On 2014/10/09 20:13:02, Yufeng Shen wrote:
> On 2014/10/09 20:11:17, danakj wrote:
> > i think clang plugin still complains about virtual with no override? anyhow
> this
> > is not related to this CL right?
> 
> Yeah, presubmit complains about it so I thought I just fix it here.
> Is the complain actually wrong ?

Do you know which presubmit check it is? (can you point me to it in cs?)

[jamesr, 2014-10-09 20:14:17]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2014-10-09 20:14:18]

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h
File cc/blink/web_layer_impl.h (right):

https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h#ne...
cc/blink/web_layer_impl.h:135:
scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo() override;
On 2014/10/09 20:13:02, Yufeng Shen wrote:
> On 2014/10/09 20:11:17, danakj wrote:
> > i think clang plugin still complains about virtual with no override? anyhow
> this
> > is not related to this CL right?
> 
> Yeah, presubmit complains about it so I thought I just fix it here.
> Is the complain actually wrong ?
Presubmit is wrong until the clang plugin actually rolls.

[chromium-reviews, 2014-10-09 20:17:35]

On Thu, Oct 9, 2014 at 4:14 PM, <danakj@chromium.org> wrote:

>
> https://codereview.chromium.org/636283003/diff/1/cc/blink/web_layer_impl.h
> File cc/blink/web_layer_impl.h (right):
>
> https://codereview.chromium.org/636283003/diff/1/cc/blink/
> web_layer_impl.h#newcode135
> cc/blink/web_layer_impl.h:135:
> scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo()
> override;
> On 2014/10/09 20:13:02, Yufeng Shen wrote:
>
>> On 2014/10/09 20:11:17, danakj wrote:
>> > i think clang plugin still complains about virtual with no override?
>>
> anyhow
>
>> this
>> > is not related to this CL right?
>>
>
>  Yeah, presubmit complains about it so I thought I just fix it here.
>> Is the complain actually wrong ?
>>
>
> Do you know which presubmit check it is? (can you point me to it in cs?)
>




https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/cppl...

I think

>
> https://codereview.chromium.org/636283003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2014-10-09 20:20:09]

On Thu, Oct 9, 2014 at 4:17 PM, Yufeng Shen <miletus@google.com> wrote:

>
>
> On Thu, Oct 9, 2014 at 4:14 PM, <danakj@chromium.org> wrote:
>
>>
>> https://codereview.chromium.org/636283003/diff/1/cc/blink/
>> web_layer_impl.h
>> File cc/blink/web_layer_impl.h (right):
>>
>> https://codereview.chromium.org/636283003/diff/1/cc/blink/
>> web_layer_impl.h#newcode135
>> cc/blink/web_layer_impl.h:135:
>> scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo()
>> override;
>> On 2014/10/09 20:13:02, Yufeng Shen wrote:
>>
>>> On 2014/10/09 20:11:17, danakj wrote:
>>> > i think clang plugin still complains about virtual with no override?
>>>
>> anyhow
>>
>>> this
>>> > is not related to this CL right?
>>>
>>
>>  Yeah, presubmit complains about it so I thought I just fix it here.
>>> Is the complain actually wrong ?
>>>
>>
>> Do you know which presubmit check it is? (can you point me to it in cs?)
>>
>
>
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/cppl...
>

Ah :( Not even in chromium per-se. Just ignore it for now then.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yufeng Shen (Slow to review), 2014-10-09 20:22:13]

On 2014/10/09 20:20:09, danakj wrote:
> On Thu, Oct 9, 2014 at 4:17 PM, Yufeng Shen <mailto:miletus@google.com> wrote:
> 
> >
> >
> > On Thu, Oct 9, 2014 at 4:14 PM, <mailto:danakj@chromium.org> wrote:
> >
> >>
> >> https://codereview.chromium.org/636283003/diff/1/cc/blink/
> >> web_layer_impl.h
> >> File cc/blink/web_layer_impl.h (right):
> >>
> >> https://codereview.chromium.org/636283003/diff/1/cc/blink/
> >> web_layer_impl.h#newcode135
> >> cc/blink/web_layer_impl.h:135:
> >> scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo()
> >> override;
> >> On 2014/10/09 20:13:02, Yufeng Shen wrote:
> >>
> >>> On 2014/10/09 20:11:17, danakj wrote:
> >>> > i think clang plugin still complains about virtual with no override?
> >>>
> >> anyhow
> >>
> >>> this
> >>> > is not related to this CL right?
> >>>
> >>
> >>  Yeah, presubmit complains about it so I thought I just fix it here.
> >>> Is the complain actually wrong ?
> >>>
> >>
> >> Do you know which presubmit check it is? (can you point me to it in cs?)
> >>
> >
> >
> >
> >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/cppl...
> >
> 
> Ah :( Not even in chromium per-se. Just ignore it for now then.
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

done.

[danakj, 2014-10-09 20:23:16]

LGTM

[danakj, 2014-10-09 20:23:19]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-10-09 20:23:20]

The CQ bit was unchecked by danakj@chromium.org

[Yufeng Shen (Slow to review), 2014-10-10 13:59:37]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-10-10 14:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/636283003/140001

[commit-bot: I haz the power, 2014-10-10 15:39:36]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2014-10-10 15:40:22]

Patchset 2 (id:??) landed as
https://crrev.com/d2061d67be46908bb069329c9278a98ad39fc8cb
Cr-Commit-Position: refs/heads/master@{#299120}